[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5194: Move table config into pinot-spi

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5194: Move table config into pinot-spi
URL: https://github.com/apache/incubator-pinot/pull/5194#discussion_r399872431
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
 ##########
 @@ -200,14 +201,7 @@ private void createRateLimiter(String tableNameWithType, ExternalView brokerReso
     LOGGER.info("The number of online brokers for table {} is {}", tableNameWithType, onlineCount);
 
     // Get the dynamic rate
-    double overallRate;
-    if (quotaConfig.isMaxQueriesPerSecondValid()) {
-      overallRate = Double.parseDouble(quotaConfig.getMaxQueriesPerSecond());
-    } else {
-      LOGGER.error("Failed to init qps quota: error when parsing qps quota: {} for table: {}",
-          quotaConfig.getMaxQueriesPerSecond(), tableNameWithType);
-      return;
-    }
+    double overallRate = Double.parseDouble(quotaConfig.getMaxQueriesPerSecond());
 
 Review comment:
   Already fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org