Re: [PR] Introduce Quota resource statement API [cloudstack]

["gp-santos (via GitHub)" <gi...@apache.org>]

gp-santos commented on code in PR #13236:
URL: https://github.com/apache/cloudstack/pull/13236#discussion_r3343895123


##########
framework/quota/src/main/java/org/apache/cloudstack/quota/dao/QuotaUsageJoinDaoImpl.java:
##########
@@ -71,11 +71,13 @@ private void prepareQuotaUsageSearchBuilder(SearchBuilder<QuotaUsageJoinVO> sear
     }
 
     @Override
-    public List<QuotaUsageJoinVO> findQuotaUsage(Long accountId, Long domainId, Integer usageType, Long resourceId, Long networkId, Long offeringId, Date startDate, Date endDate, Long tariffId) {
+    public List<QuotaUsageJoinVO> findQuotaUsage(Long accountId, List<Long> domainIds, Integer usageType, Long resourceId, Long networkId, Long offeringId, Date startDate, Date endDate, Long tariffId) {
         SearchCriteria<QuotaUsageJoinVO> sc = tariffId == null ? searchQuotaUsages.create() : searchQuotaUsagesJoinTariffUsages.create();
 
         sc.setParametersIfNotNull("accountId", accountId);
-        sc.setParametersIfNotNull("domainId", domainId);
+        if (domainIds != null) {

Review Comment:
   Maybe `!ObjectUtils.isEmpty()`? Just in case someone uses it with an empty list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org