You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "miland-db (via GitHub)" <gi...@apache.org> on 2025/08/21 08:15:31 UTC
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
miland-db commented on code in PR #52086:
URL: https://github.com/apache/spark/pull/52086#discussion_r2290273275
##########
sql/core/src/test/resources/sql-tests/inputs/sql-session-variables.sql:
##########
@@ -215,8 +207,29 @@ DROP TEMPORARY VARIABLE var1;
DROP TEMPORARY VARIABLE var2;
DROP TEMPORARY VARIABLE var3;
-DECLARE VARIABLE var1, var2, vAr1 INT;
+SET VARIABLE title = 'DECLARE VARIABLE - multiple variables defined at once';
Review Comment:
nit: multiple variables `declared` at one
##########
sql/core/src/test/resources/sql-tests/inputs/sql-session-variables.sql:
##########
@@ -215,8 +207,29 @@ DROP TEMPORARY VARIABLE var1;
DROP TEMPORARY VARIABLE var2;
DROP TEMPORARY VARIABLE var3;
-DECLARE VARIABLE var1, var2, vAr1 INT;
+SET VARIABLE title = 'DECLARE VARIABLE - multiple variables defined at once';
Review Comment:
nit: multiple variables `declared` at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org