You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Adam (Created) (JIRA)" <ji...@apache.org> on 2011/10/17 07:46:11 UTC
[jira] [Created] (CAMEL-4549) Add support for PGP to camel-crypto
Add support for PGP to camel-crypto
-----------------------------------
Key: CAMEL-4549
URL: https://issues.apache.org/jira/browse/CAMEL-4549
Project: Camel
Issue Type: Improvement
Components: bean-integration
Affects Versions: 2.9.0
Reporter: Adam
Fix For: 2.9.0
This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
- Add PGPDataFormat
- Introduce the use of bouncycastle, it was previously only a "test" resource
Notes:
- The camel-crypto "component" did not exist in Jira, could you please add it.
- Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
- The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: (was: camel-crypt-add-pgp.patch)
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: pgp.patch
Minor bug fix for public key search and updated documentation snippet tags to be used by wiki
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: secring.gpg
pubring.gpg
camel-crypt-add-pgp.patch
Patch file and the pgp keyring to support the tests.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: bean-integration
> Affects Versions: 2.9.0
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133408#comment-13133408 ]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Thanks Adam for the new patch.
To have it working in osgi we need SMX4-947 fixed beforehand.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: pgpcrypto.patch
new patch
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: (was: pgpcrypto.patch)
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144561#comment-13144561 ]
Adam commented on CAMEL-4549:
-----------------------------
Thanks for commiting the code Claus.
I have updated the wiki page for the crypto component and added a PGPDataFormat section. https://cwiki.apache.org/confluence/display/CAMEL/Crypto
I used the snippet library in the wiki, so I updated the test scripts with the tags. I also fixed a small bug I ran into on my side relating to the public key search utility.
Can you please commit the attached patch to the trunk.
Thanks.
Will this make it into the 2.9.x branch?
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Patch Info: Patch Available
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: bean-integration
> Affects Versions: 2.9.0
> Reporter: Adam
> Fix For: 2.9.0
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130411#comment-13130411 ]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Adam do you mind re-attaching your patch and make sure you mark [x] in grant license to Apache. eg there should be an Apache feather icon at the attachments.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pgpcrypto.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144623#comment-13144623 ]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Thanks for the 2nd patch. Applied to trunk.
Would be good if the PGP data format could have a table like the other which lists all the options and explains them.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-4549:
----------------------------------
Assignee: Claus Ibsen
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136050#comment-13136050 ]
Adam commented on CAMEL-4549:
-----------------------------
Thanks Claus, looks like JB resolved the dependency issue with the osgi bundle(Thanks JB). Can CAMEL-4549 be included in the 2.9.0 release?
Please note the version dependency change that is required in parent/pom.xml of bouncy castle as follows:
<bouncycastle-version>1.46</bouncycastle-version>
It should be removed from the hard-coded version number in the camel-crypto/pom.xml and moved to parent/pom.xml
If this should be a separate ticket, please let me know and i'll create one.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143987#comment-13143987 ]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Adam do you mind working on wiki documentation for this new feature?
See about improving doc and how edit website works
http://camel.apache.org/contributing.html
If you need to edit directly you need an ICLA on file at Apache.
You can also just attach a .txt file to this JIRA with some documentation.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: pgpcrypto.patch
missed public modifiers in utility class.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pgpcrypto.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129489#comment-13129489 ]
Adam commented on CAMEL-4549:
-----------------------------
Thanks Claus, really appreciate the feedback with my first contribution.
Attached is a new patch with the checkstyle resolved as well as the static initializer removed.
Please let me know when it's added to the trunk and I can update the wiki.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144640#comment-13144640 ]
Adam commented on CAMEL-4549:
-----------------------------
table created
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128692#comment-13128692 ]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Thanks for working on such an improvement.
If you are familiar with running maven, then you may want to ensure the source code follow our standard layout, which you can check using a maven goal named checkstyle. You can read about building the source with checkstyle here
http://camel.apache.org/building.html
Also you have a static initializer to add BouncyCastle as a provider. I wonder how well that works with OSGi and IBM JDKs etc. Also static initializers tend to have problems in trouble shooting as any exceptions thrown may not be logged etc.
You can implement org.apache.camel.Service in the DataFormat, and in the start method, add the provider. Then have a static field with a state so you know you only add it once. And maybe check that its not already added etc. As some other library may have added it etc.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam updated CAMEL-4549:
------------------------
Attachment: pgpcrypto.patch
re-attached.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pgpcrypto.patch, pgpcrypto.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-4549:
-------------------------------
Component/s: (was: bean-integration)
camel-crypto
Affects Version/s: (was: 2.9.0)
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144023#comment-13144023 ]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Thanks for the patch applied to trunk. We need documentation before we can close this ticket.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-4549) Add support for PGP to camel-crypto
Posted by "Claus Ibsen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-4549.
--------------------------------
Resolution: Fixed
Thanks.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Assignee: Claus Ibsen
> Fix For: 2.9.0
>
> Attachments: pgp.patch, pgpcrypto.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira