[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #677: fix(c/driver/snowflake): fix validation test failures

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #677:
URL: https://github.com/apache/arrow-adbc/pull/677#discussion_r1190391864


##########
go/adbc/driver/snowflake/record_reader.go:
##########
@@ -219,7 +219,7 @@ func getTransformer(sc *arrow.Schema, ld gosnowflake.ArrowStreamLoader) (*arrow.
 		default:
 			transformers[i] = identCol
 		}
-
+		f.Name = strings.ToLower(f.Name)

Review Comment:
   I'm not sure. Unfortunately we're probably gonna run into this more as we add more drivers. Snowflake currently returns *everything* unconditionally upper-cased as far as I can tell. While our tests expect things to be lower cased. I personally prefer consistency so I like the idea of saying we lower case the field names..... but I dunno.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org