You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org> on 2016/06/27 21:13:30 UTC

[kudu-CR](gh-pages) kudu flume sink blog post

Ara Ebrahimi has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3510

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-07-06-flume.md
1 file changed, 141 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org>.
Ara Ebrahimi has uploaded a new patch set (#5).

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-07-06-flume.md
1 file changed, 262 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 4:

(32 comments)

Thanks for the update, Ara! I've provided a bunch of feedback.

Also, if you don't mind, please remove the trailing spaces in the file (they are highlighted in red on Gerrit)

http://gerrit.cloudera.org:8080/#/c/3510/4/_posts/2016-07-06-flume.md
File _posts/2016-07-06-flume.md:

Line 25: So, in a nutshell, _batch processing_ is:
s/So, in a nutshell/To summarize/


Line 27: - primitive
I don't really understand what you mean by primitive here. I would consider removing this dimension of the comparison. An example is Spark, which is batch oriented but quite rich in its APIs and capabilities, I think.


Line 29: - batch-oriented
How about: s/batch-oriented/a paradigm that processes large chunks of data as a group/


Line 30: - fast ingest, slow query 
high latency and high throughput, both for ingest and query


Line 31: - easy to program, but hard to orchestrate
typically easy to program


Line 32: - easy to write ad-hoc, though slow, queries
well suited for writing ad-hoc queries, although they are typically high latency


Line 36: - not primitive, has rich constructs such as time windows
s/not primitive, has rich constructs such as time windows/a totally different paradigm, which involves single events and time windows instead of large groups of events/


Line 37: - still file-based and not a long-term database
typically still file-oriented, instead of table-oriented


Line 39: - ultra-fast ingest and ultra-fast query (query results basically pre-calculated)
very low latency and often low throughput both for ingest and query (query results are typically pre-calculated at ingest time)


Line 40: - not so easy to program, relatively easy to orchestrate
often difficult to program for


Line 45: - not primitive, thanks to SQL support via Impala
flexible and expressive, thanks to SQL support via Apache Impala (incubating)


Line 46: - a real long-term database, with SQL support via Impala
a table-oriented, mutable data store that feels like a traditional relational database


Line 47: - neither batch nor streaming
I'm not sure what you mean by neither batch or streaming. maybe just remove this?


Line 48: - fast ingest and fast query
low-latency and relatively high throughput, both for ingest and query


Line 83: can see, nowhere Hadoop is mentioned but Flume is typically used for ingesting data to Hadoop
s/nowhere Hadoop is mentioned/nowhere is Hadoop mentioned/


PS4, Line 88: _agent_
add a comma after _agent_


PS4, Line 129: vmstat
`vmstat`


PS4, Line 132: SimpleKuduEventProducer
`SimpleKuduEventProducer`


PS4, Line 135: KuduSink
`KuduSink`


PS4, Line 136: from Kudu distributio
from the Kudu distribution


Line 137: `$FLUME_HOME/plugins.d/kudu-sink/lib` in the Flume installation. The jar file contains KuduSink
missing word: `$FLUME_HOME/plugins.d/kudu-sink/lib` directory


PS4, Line 137: KuduSink
`KuduSink`


Line 138: and all the dependencies of it (including Kudu java client classes).
s/and all the dependencies of it/and all of its dependencies/


PS4, Line 142: Kudu Flume Sink
The Kudu Flume Sink


PS4, Line 143: it runs
before the Kudu Flume Sink is started.


PS4, Line 205: SimpleKuduEventProducer
`SimpleKuduEventProducer`


PS4, Line 236: from 
from the


PS4, Line 238: SimpleKuduEventProducer
`SimpleKuduEventProducer`


Line 248: on the built-in ones.
Add: In the future, we plan to add more flexible event producer implementations so that creation of a custom event producer is not required to write data to Kudu. See here for a work-in-progress generic event producer for Avro-encoded Events: https://gerrit.cloudera.org/#/c/4034/


Line 252: Kudu is a scalable database which lets us ingest insane amounts of data per second. Apache Flume
s/database/data store/


PS4, Line 253: library
s/library//


Line 256
At the end, if you want to, consider adding a bio paragraph about yourself in italics. Maybe something like this?

Ara Abrahamian is a software engineer at Argyle Data building X. <insert whatever else you want about yourself>. Ara is the original author of the Flume Kudu Sink that is included in the Kudu distribution.


-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3510

to look at the new patch set (#7).

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-08-31-intro-flume-kudu-sink.md
1 file changed, 261 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org>.
Ara Ebrahimi has uploaded a new patch set (#6).

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-08-31-intro-flume-kudu-sink.md
1 file changed, 261 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 5:

> Let's publish tomorrow.
 > 
 > Please rename the file to 2016-08-07-intro-flume-kudu-sink.md

Oops, my mistake. Please rename to 2016-08-31-intro-flume-kudu-sink.md

-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: kudu flume sink blog post
......................................................................


kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Reviewed-on: http://gerrit.cloudera.org:8080/3510
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
A _posts/2016-08-31-intro-flume-kudu-sink.md
1 file changed, 261 insertions(+), 0 deletions(-)

Approvals:
  Mike Percy: Verified
  Todd Lipcon: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3510/6/_posts/2016-08-31-intro-flume-kudu-sink.md
File _posts/2016-08-31-intro-flume-kudu-sink.md:

PS6, Line 68: Cloudera
sorry, one nit: This should be Apache Impala (incubating)


-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3510/6/_posts/2016-08-31-intro-flume-kudu-sink.md
File _posts/2016-08-31-intro-flume-kudu-sink.md:

PS6, Line 68: Cloudera
> sorry, one nit: This should be Apache Impala (incubating)
We already mentioned Apache Impala (incubating) above, so this can just read "Impala". Yes, we should remove Cloudera from this line.


-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 6: Code-Review+2 Verified+1

Thanks Ara! I'll push this live tomorrow morning.

-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 1:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/3510/1/_posts/2016-07-06-flume.md
File _posts/2016-07-06-flume.md:

Line 6: In this article I will discuss the Kudu Flume Sink. But before doing that let me tell you why we considered Kudu to begin with, and what Flume does and how it fits in an architecture involving Kudu.
Consider rephrasing to something like:

This post discusses the Kudu Flume Sink. First, I'll give some background on why we considered using Kudu, what Flume does for us, and how Flume fits with Kudu in our project.


Line 9: ====
In blog posts, lists work better than very long paragraphs. Consider distilling this content into some bullet points.


Line 10: There are many different ways of looking at Kudu. One way is to look at it as a tool which can be used to build system which are closer to _real-time_ processing of big data but without using _streaming_ software.
nit long lines (and following)

Try to stay under 100 characters to make Gerrit reviews easier.


Line 12: Traditionally in the Hadoop ecosystem we've dealt with various _batch processing_ technologies such as Map/Reduce and the many libraries and tools built on top of it in various languages (Apache Pig, Apache Hive, Apache Oozie and many other things). The main problem with this approach is that it needs to process the whole data set in batches, again and again, as soon as new data gets added. Things get really complicated when a few such tasks need to get chained together, or when the same data set needs to be processed in various ways by different jobs, while all compete for the shared cluster resources. The whole _orchestration_ becomes a nightmare over time. The opposite of this approach is _stream processing_: process the data as soon as it arrives, not in batches. Streaming systems such as Spark Streaming, Storm, Kafka Streams, and many others make that possible. But writing streaming services is not trivial. The streaming systems are becoming more and more capab!
 le and support more complex constructs, but sometimes you just long for a good old database which you can simply store data inside and then query and write business logic on top. No slowness and primitiveness of batch processing, and no complexity of streaming. Something in between. That's what Kudu is, from this point of view. It's a scalable database, you can store big amounts of data in it with very impressive ingestion rates, enrich, delete and update that data, and generate views and reports. You can pretend it's a good old SQL database, but with scalability built in. The ability to use a real database instead of a bunch of files is quite empowering and leads to reduced complexity. Let's be honest, a bunch of files is not a database, and databases are popular for a reason: they enable us to write business logic on top of them with ease.
Generally, MapReduce doesn't need the / anymore.

Consider a simple diagram or flow chart to augment what you are saying here. I get it, but it is a little hard to follow just in one long paragraph.


Line 13:           
nit whitespace (and following)


Line 18: According to their website "Flume is a distributed, reliable, and available service for efficiently collecting, aggregating, and moving large amounts of log data. It has a simple and flexible architecture based on streaming data flows. It is robust and fault tolerant with tunable reliability mechanisms and many failover and recovery mechanisms." As you can see nowhere Hadoop is mentioned but Flume is typically used for ingesting data to Hadoop clusters. 
Maybe just have the quote and link to where you found it


Line 31: 
Do you need to use the back-ticks to turn this into a codeblock or is the indentation sufficient?


Line 59: Parameter Name      | Default                                       | Description
Consider formatting this as a real table or putting it into a codeblock so that it scrolls horizontally. Markdown lets you use pipes for tables, or you can code a HTML table within Markdown.


Line 70:     public class SimpleKuduEventProducer implements KuduEventProducer {
Again, make sure this ends up in a codeblock.


Line 139: Conclusion
Do you want to put some example code into Git somewhere so people  can check it out and play with it? That might be a nice thing to do.


-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org>.
Ara Ebrahimi has uploaded a new patch set (#4).

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-07-06-flume.md
1 file changed, 255 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 1:

(27 comments)

Sorry for the delay, I was out of town for a while.

Because the date already passed, let's shoot for a publish date of 2016-07-08 or 2016-07-12.

http://gerrit.cloudera.org:8080/#/c/3510/1/_posts/2016-07-06-flume.md
File _posts/2016-07-06-flume.md:

Line 3: title: "An Introduction to Kudu Flume Sink"
How about "Introduction to the Kudu Flume Sink"?


Line 10: There are many different ways of looking at Kudu. One way is to look at it as a tool which can be used to build system which are closer to _real-time_ processing of big data but without using _streaming_ software.
typo: s/system/systems/


Line 12: Traditionally in the Hadoop ecosystem we've dealt with various _batch processing_ technologies such as Map/Reduce and the many libraries and tools built on top of it in various languages (Apache Pig, Apache Hive, Apache Oozie and many other things). The main problem with this approach is that it needs to process the whole data set in batches, again and again, as soon as new data gets added. Things get really complicated when a few such tasks need to get chained together, or when the same data set needs to be processed in various ways by different jobs, while all compete for the shared cluster resources. The whole _orchestration_ becomes a nightmare over time. The opposite of this approach is _stream processing_: process the data as soon as it arrives, not in batches. Streaming systems such as Spark Streaming, Storm, Kafka Streams, and many others make that possible. But writing streaming services is not trivial. The streaming systems are becoming more and more capab!
 le and support more complex constructs, but sometimes you just long for a good old database which you can simply store data inside and then query and write business logic on top. No slowness and primitiveness of batch processing, and no complexity of streaming. Something in between. That's what Kudu is, from this point of view. It's a scalable database, you can store big amounts of data in it with very impressive ingestion rates, enrich, delete and update that data, and generate views and reports. You can pretend it's a good old SQL database, but with scalability built in. The ability to use a real database instead of a bunch of files is quite empowering and leads to reduced complexity. Let's be honest, a bunch of files is not a database, and databases are popular for a reason: they enable us to write business logic on top of them with ease.
nit: Please wrap this line and all the others (except for code examples) to 100 chars.


PS1, Line 14: Impala, Cloudera's
s/Impala, Cloudera's query engine/Apache Impala (incubating), a SQL query engine/

(Cloudera doesn't own Impala anymore; it's been donated to the ASF)


PS1, Line 14: quite similar to Accumulo
how about: quite similar to Accumulo (but, at the time of writing, without Accumulo's security features)


PS1, Line 18: As you can
nit: add a comma. "As you can see,"


PS1, Line 18: website
link the web site: http://flume.apache.org


PS1, Line 24: sources
For the sources sentence, consider replacing this with:

Several sources are provided out of the box with Flume, including a REST-based API, Avro and Thrift based APIs, a JMS connector, and sources that implement various ways to read files from disk.


PS1, Line 24: JDBC, Kafka and File
Let's not mention the JDBC channel, since it's not recommended for use.

How about: "other options such as Kafka- and File-based channels are also provided."


PS1, Line 24: Sinks
For the sinks part, how about saying:

Flume also ships with many sinks, including sinks to write data to HDFS, HBase, Hive, Kafka, as well as to other Flume agents.


PS1, Line 26: cloudera
Please use the following repository when linking: github.com/apache/incubator-kudu


Line 28: Configuring Kudu Flume Sink
Nit: Configuring the Kudu Flume Sink


Line 31: 
> Do you need to use the back-ticks to turn this into a codeblock or is the i
It looks like the indentation is sufficient.


PS1, Line 51: `lib` directory
Instead of the Flume lib directory, the jar file should be copied into the directory $FLUME_HOME/plugins.d/kudu-sink/lib. Details here: https://flume.apache.org/FlumeUserGuide.html#installing-third-party-plugins


PS1, Line 51: show case
nit: showcase


PS1, Line 53: The minimum configuration for KuduSink
At a minimum, the KuduSink


PS1, Line 53: Kudu Flume Sink
nit: The Kudu Flume Sink


Line 59: Parameter Name      | Default                                       | Description
> Consider formatting this as a real table or putting it into a codeblock so 
This renders as a table for me when viewed through Jekyll. It would be nice if the font size was a little smaller but that's not something that can be controlled through the Markdown.


Line 70:     public class SimpleKuduEventProducer implements KuduEventProducer {
> Again, make sure this ends up in a codeblock.
This renders as code for me.


PS1, Line 135: holds
which will hold


PS1, Line 135: payload
Use double-quotes for "payload", not single-quotes


PS1, Line 135: vmstat
from the `vmstat` command.


PS1, Line 135: KuduSink
the KuduSink


PS1, Line 135: KuduSink
"by the KuduSink."


PS1, Line 141: are
lets us


PS1, Line 141: seconds
per second


PS1, Line 141: create data lakes
create a data lake


-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 5:

Let's publish tomorrow.

Please rename the file to 2016-08-07-intro-flume-kudu-sink.md

-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org>.
Ara Ebrahimi has uploaded a new patch set (#2).

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-07-06-flume.md
1 file changed, 182 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Ara Ebrahimi (Code Review)" <ge...@cloudera.org>.
Ara Ebrahimi has uploaded a new patch set (#3).

Change subject: kudu flume sink blog post
......................................................................

kudu flume sink blog post

Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
---
A _posts/2016-07-06-flume.md
1 file changed, 255 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3510/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) kudu flume sink blog post

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: kudu flume sink blog post
......................................................................


Patch Set 5:

(1 comment)

We need to rename the file to the date it will get posted. Let me collect some opinions and get back to you on the publish date.

http://gerrit.cloudera.org:8080/#/c/3510/5/_posts/2016-07-06-flume.md
File _posts/2016-07-06-flume.md:

Line 48: - low-latency and relatively high throughput, both for ingest and query
this seems to duplicate "fast ingest and fast query"


-- 
To view, visit http://gerrit.cloudera.org:8080/3510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Ara Ebrahimi <ar...@argyledata.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes