You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Otis Gospodnetic (JIRA)" <ji...@apache.org> on 2012/06/06 13:04:22 UTC
[jira] [Created] (HBASE-6170) Timeouts for row lock and scan should
be separate
Otis Gospodnetic created HBASE-6170:
---------------------------------------
Summary: Timeouts for row lock and scan should be separate
Key: HBASE-6170
URL: https://issues.apache.org/jira/browse/HBASE-6170
Project: HBase
Issue Type: Improvement
Components: regionserver
Affects Versions: 0.94.0
Reporter: Otis Gospodnetic
Priority: Minor
Fix For: 0.96.0
Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
(opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402407#comment-13402407 ]
Chris Trezzo commented on HBASE-6170:
-------------------------------------
I greped through the FindBugs report and I didn't really see anything that was related. It was complaining about synchronization in the leases class, but that was there before the change.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401721#comment-13401721 ]
Zhihong Ted Yu commented on HBASE-6170:
---------------------------------------
Minor comment:
{code}
+ * The lease timeout period for client scans (milliseconds).
+ */
+ private final int scannerLeaseTimeoutPeriod;
{code}
'client scans' -> 'client scanners'
{code}
- this.leases = new Leases((int) conf.getLong(
+ this.leases = new Leases(conf.getInt(
{code}
I would suggest changing the getInt() calls back to getLong().
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402682#comment-13402682 ]
Hudson commented on HBASE-6170:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #72 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/72/])
HBASE-6170 add the two new config parameters in hbase-default.xml (Revision 1354500)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401971#comment-13401971 ]
Anoop Sam John commented on HBASE-6170:
---------------------------------------
@Ted
So in trunk "hbase.regionserver.lease.period" property is removed now?
This is referred in the hbase-default.xml also. Better can change there too..
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403829#comment-13403829 ]
Lars Francke commented on HBASE-6170:
-------------------------------------
This introduced wrong indentation: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java?r1=1354325&r2=1354324&pathrev=1354325
Can I find the Findbugs report online somewhere?
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402397#comment-13402397 ]
Jesse Yates commented on HBASE-6170:
------------------------------------
Are we sure that this didn't introduce any findbugs problems that might be a problem? I thought we had fixed the findbugs new-problem finding, so we need to make sure that no new bugs were actually introduced or if they were, that we consider them ok.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404079#comment-13404079 ]
Hudson commented on HBASE-6170:
-------------------------------
Integrated in HBase-TRUNK #3086 (See [https://builds.apache.org/job/HBase-TRUNK/3086/])
HBASE-6170 Addendum 2 fixes indentation issue Lars Francke found (Revision 1355464)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.add2, 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6170:
----------------------------------
Status: Open (was: Patch Available)
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6170:
----------------------------------
Release Note:
hbase.regionserver.rowlock.timeout.period controls the timeout for rowlock. Default is 60 seconds.
hbase.client.scanner.timeout.period controls scanner timeout. Default is 60 seconds.
Hadoop Flags: Reviewed
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6170:
--------------------------------
Status: Patch Available (was: Open)
Submitting patch for QA run.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6170:
--------------------------------
Attachment: HBASE-6170v1.patch
Attached is a first patch for this issue.
I have added two config parameters (and associated defaults) in HConstants:
HBASE_REGIONSERVER_ROWLOCK_TIMEOUT_PERIOD
HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD
Now, each lease in Leases.java can specify their own timeout period. If no timeout period is specified, the original HBASE_REGIONSERVER_LEASE_PERIOD_KEY parameter is used as default.
I ran the TestScannerTimeout tests and everything passed. I will submit the patch and get a QA run.
Comments are welcome.
Thanks,
Chris
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401782#comment-13401782 ]
Zhihong Ted Yu commented on HBASE-6170:
---------------------------------------
Usage in existing code base is inconsistent:
{code}
- conf.setInt(
- HConstants.HBASE_REGIONSERVER_LEASE_PERIOD_KEY, SCANNER_TIMEOUT*100);
{code}
I am fine with aligning to integer.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6170:
----------------------------------
Attachment: 6170.addendum
Addendum that modifies hbase-default.xml
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401964#comment-13401964 ]
Zhihong Ted Yu commented on HBASE-6170:
---------------------------------------
Patch v4 integrated to trunk.
Thanks for the patch, Chris.
Thanks for the review, Jesse.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6170:
--------------------------------
Attachment: HBASE-6170v1.patch
One more run.
Chris
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401638#comment-13401638 ]
Hadoop QA commented on HBASE-6170:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533519/HBASE-6170v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
org.apache.hadoop.hbase.client.TestAdmin
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2264//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2264//console
This message is automatically generated.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402272#comment-13402272 ]
Hudson commented on HBASE-6170:
-------------------------------
Integrated in HBase-TRUNK #3080 (See [https://builds.apache.org/job/HBase-TRUNK/3080/])
HBASE-6170 add the two new config parameters in hbase-default.xml (Revision 1354500)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401747#comment-13401747 ]
Hadoop QA commented on HBASE-6170:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533542/HBASE-6170v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2265//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2265//console
This message is automatically generated.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402157#comment-13402157 ]
Hudson commented on HBASE-6170:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #71 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/71/])
HBASE-6170 Timeouts for row lock and scan should be separate (Chris Trezzo) (Revision 1354325)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Leases.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401810#comment-13401810 ]
Hadoop QA commented on HBASE-6170:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533555/HBASE-6170v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestAtomicOperation
org.apache.hadoop.hbase.security.access.TestAccessController
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2266//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2266//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2266//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2266//console
This message is automatically generated.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401769#comment-13401769 ]
Jesse Yates commented on HBASE-6170:
------------------------------------
Minor note: ints seem to be sufficient for basically all the use cases that I've heard of (24 days scanner timeout/lease timeout seems massive). Using ints over longs here is a nice space savings (though relatively trivial, bits count with GC).
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401771#comment-13401771 ]
Chris Trezzo commented on HBASE-6170:
-------------------------------------
@Ted Does that make sense, or am I missing something?
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo resolved HBASE-6170.
---------------------------------
Resolution: Fixed
Patch is committed.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.add2, 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6170:
--------------------------------
Attachment: HBASE-6170v3.patch
@Ted Thanks!
Removed HBASE_REGIONSERVER_LEASE_PERIOD_KEY and DEFAULT_HBASE_REGIONSERVER_LEASE_PERIOD. Now the usage should be consistent within the code.
Also TestAtomicOperation and TestAccessController tests are passing locally.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6170:
--------------------------------
Attachment: HBASE-6170v2.patch
@Ted. Thanks for the reply! I have corrected the comment in HRegionServer.
Regarding your second comment, I am not sure I see the need to switch getInt back to getLong. Internally, the timeout value is treated as an int. There is a hidden potential for precision loss if a client uses a long in the config file. Changing everything to getInt removes the cast and makes the internal/external representation of the timeout period consistent.
Going forward, if we decide that the extra bits in a long are needed (i.e. a use case that requires timeout periods longer than 24 days), existing configurations will not be broken and the switch to longs will require minimal code changes.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404324#comment-13404324 ]
Hudson commented on HBASE-6170:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #75 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/75/])
HBASE-6170 Addendum 2 fixes indentation issue Lars Francke found (Revision 1355464)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.add2, 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6170:
----------------------------------
Release Note:
"hbase.regionserver.lease.period" is no longer supported.
hbase.regionserver.rowlock.timeout.period controls the timeout for rowlock. Default is 60 seconds.
hbase.client.scanner.timeout.period controls scanner timeout. Default is 60 seconds.
was:
hbase.regionserver.rowlock.timeout.period controls the timeout for rowlock. Default is 60 seconds.
hbase.client.scanner.timeout.period controls scanner timeout. Default is 60 seconds.
Hadoop Flags: Incompatible change,Reviewed (was: Reviewed)
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6170:
----------------------------------
Attachment: 6170v4.patch
Patch v4 wraps a long line (HBASE_REGIONSERVER_ROWLOCK_TIMEOUT_PERIOD).
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6170:
--------------------------------
Attachment: HBASE-6170v1.patch
Last run failed due to OOM exception. Resubmitting the patch to get another run.
Chris
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401846#comment-13401846 ]
Hadoop QA commented on HBASE-6170:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533566/HBASE-6170v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2267//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2267//console
This message is automatically generated.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401972#comment-13401972 ]
Ted Yu commented on HBASE-6170:
-------------------------------
Good idea. Will do tomorrow.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo reassigned HBASE-6170:
-----------------------------------
Assignee: Chris Trezzo
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401981#comment-13401981 ]
Hudson commented on HBASE-6170:
-------------------------------
Integrated in HBase-TRUNK #3079 (See [https://builds.apache.org/job/HBase-TRUNK/3079/])
HBASE-6170 Timeouts for row lock and scan should be separate (Chris Trezzo) (Revision 1354325)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Leases.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6170) Timeouts for row lock and scan should
be separate
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6170:
----------------------------------
Attachment: 6170.add2
Addendum 2 addresses Lars F's finding.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6170.add2, 6170.addendum, 6170v4.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v1.patch, HBASE-6170v2.patch, HBASE-6170v3.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6170) Timeouts for row lock and scan
should be separate
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401219#comment-13401219 ]
Hadoop QA commented on HBASE-6170:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533425/HBASE-6170v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2255//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2255//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2255//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2255//console
This message is automatically generated.
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
> Key: HBASE-6170
> URL: https://issues.apache.org/jira/browse/HBASE-6170
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Otis Gospodnetic
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global. It would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira