You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2022/04/02 08:09:24 UTC

[servicecomb-java-chassis] branch master updated: log number not correct (#2761)

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new fb04957  log number not correct (#2761)
fb04957 is described below

commit fb04957b3fac34b119f3e1c4904b8ce026052f24
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Sat Apr 2 16:08:18 2022 +0800

    log number not correct (#2761)
---
 .../protobuf/internal/schema/deserializer/MessageReadSchema.java        | 2 +-
 .../main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java    | 2 +-
 .../org/apache/servicecomb/provider/pojo/FilterInvocationCaller.java    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/deserializer/MessageReadSchema.java b/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/deserializer/MessageReadSchema.java
index b8d16cf..7327119 100644
--- a/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/deserializer/MessageReadSchema.java
+++ b/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/deserializer/MessageReadSchema.java
@@ -166,7 +166,7 @@ public class MessageReadSchema<T> implements SchemaEx<T> {
     } catch (Throwable e) {
       if (fieldSchema != null) {
         Field protoField = fieldSchema.getProtoField();
-        LOGGER.error("Failed to mergeFrom, field={}:{}, type={}",
+        LOGGER.error("Failed to mergeFrom, field={}:{}, type={}, error {}",
             protoField.getType().getCanonicalName(),
             protoField.getName(),
             protoField.getTypeName(),
diff --git a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
index 882dcfd..8c2f2f2 100644
--- a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
+++ b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
@@ -85,7 +85,7 @@ public abstract class BizkeeperCommand extends HystrixObservableCommand<Response
       try {
         invocation.next(resp -> {
           if (isFailedResponse(resp)) {
-            LOG.warn("bizkeeper command {} failed, trace id {}",
+            LOG.warn("bizkeeper command {} failed, trace id {} result {}",
                 invocation.getInvocationQualifiedName(),
                 invocation.getTraceId(),
                 resp.getResult());
diff --git a/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/FilterInvocationCaller.java b/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/FilterInvocationCaller.java
index ecb4358..052d4c1 100644
--- a/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/FilterInvocationCaller.java
+++ b/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/FilterInvocationCaller.java
@@ -50,7 +50,7 @@ public class FilterInvocationCaller implements InvocationCaller {
   }
 
   protected PojoInvocation logCreateInvocationException(Method method, Throwable throwable) {
-    LOGGER.error("failed to create invocation, method=", method);
+    LOGGER.error("failed to create invocation, method {}", method);
     throw Exceptions.consumer("SCB_PROVIDER_POJO.400000001", "failed to create invocation.", throwable);
   }
 }