[jira] [Commented] (HIVE-7920) Fix issues with NotificationListener (finalize, overwriting of table properties, Checkstyle)

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116240#comment-14116240 ] 

Hive QA commented on HIVE-7920:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12665525/HIVE-7920.1.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6132 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.pig.TestHCatLoader.testReadDataPrimitiveTypes
org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/573/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/573/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-573/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12665525

> Fix issues with NotificationListener (finalize, overwriting of table properties, Checkstyle)
> --------------------------------------------------------------------------------------------
>
>                 Key: HIVE-7920
>                 URL: https://issues.apache.org/jira/browse/HIVE-7920
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7920.1.patch
>
>
> This cleans up {{NotificationListener}}.
> * It was using a finalize method which is generally a bad idea and doesn't help here as the class will be collected by GC anyway when the Metastore shuts down.
> * In {{onCreateTable}} it would unconditionally overwrite the property for the topic name which could have been specified as part of the table creation
> * Adds detailed documentation to almost each method
> * Fixes Checkstyle issues like long lines and unnecessary protected access



--
This message was sent by Atlassian JIRA
(v6.2#6252)