You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/27 08:19:42 UTC
[GitHub] [iotdb] THUMarkLau opened a new pull request #5127: [IOTDB-2612] Fix cannot select compaction candidate after exception occurrence in previous compaction
THUMarkLau opened a new pull request #5127:
URL: https://github.com/apache/iotdb/pull/5127
see [IOTDB-2612](https://issues.apache.org/jira/browse/IOTDB-2612)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #5127: [IOTDB-2612] Fix cannot select compaction candidate after exception occurrence in previous compaction
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #5127:
URL: https://github.com/apache/iotdb/pull/5127#discussion_r815704998
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -95,7 +87,7 @@ public String toString() {
@Override
public void resetCompactionCandidateStatusForAllSourceFiles() {
Review comment:
resolve
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/AbstractInnerSpaceCompactionTask.java
##########
@@ -131,6 +127,6 @@ public String toString() {
@Override
public void resetCompactionCandidateStatusForAllSourceFiles() {
Review comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5127: [IOTDB-2612] Fix cannot select compaction candidate after exception occurrence in previous compaction
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5127:
URL: https://github.com/apache/iotdb/pull/5127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #5127: [IOTDB-2612] Fix cannot select compaction candidate after exception occurrence in previous compaction
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #5127:
URL: https://github.com/apache/iotdb/pull/5127#discussion_r815435204
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/AbstractInnerSpaceCompactionTask.java
##########
@@ -131,6 +127,6 @@ public String toString() {
@Override
public void resetCompactionCandidateStatusForAllSourceFiles() {
Review comment:
```suggestion
public void resetCompactionStatusForAllSourceFiles() {
```
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -95,7 +87,7 @@ public String toString() {
@Override
public void resetCompactionCandidateStatusForAllSourceFiles() {
Review comment:
```suggestion
public void resetCompactionStatusForAllSourceFiles() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5127: [IOTDB-2612] Fix cannot select compaction candidate after exception occurrence in previous compaction
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5127:
URL: https://github.com/apache/iotdb/pull/5127#issuecomment-1054250431
[](https://coveralls.io/builds/46930794)
Coverage increased (+0.02%) to 67.746% when pulling **36ede245859fb667bd00f30b0a7564aded98ee2b on THUMarkLau:IOTDB-2612** into **e44835f0b60ad7c360f87125a2ad4e63f383b250 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org