You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/15 09:17:10 UTC
[GitHub] [incubator-doris] mrhhsg opened a new pull request, #10161: [imporement]Avoid unnecessary find_codes in predicate
mrhhsg opened a new pull request, #10161:
URL: https://github.com/apache/incubator-doris/pull/10161
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10161:
URL: https://github.com/apache/incubator-doris/pull/10161#issuecomment-1158486761
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10161:
URL: https://github.com/apache/doris/pull/10161#discussion_r899946704
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -914,6 +914,7 @@ void SegmentIterator::_evaluate_short_circuit_predicate(uint16_t* vec_sel_rowid_
predicate->type() == PredicateType::GT || predicate->type() == PredicateType::GE) {
col_ptr->convert_dict_codes_if_necessary();
}
+ predicate->set_dict_code_if_necessary(*short_cir_column, _segment->id());
Review Comment:
Segment id is unique in a single rowset, it is not unique between different rowsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10161:
URL: https://github.com/apache/incubator-doris/pull/10161#issuecomment-1158486752
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg closed pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
Posted by GitBox <gi...@apache.org>.
mrhhsg closed pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
URL: https://github.com/apache/doris/pull/10161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zenoyang commented on a diff in pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
Posted by GitBox <gi...@apache.org>.
zenoyang commented on code in PR #10161:
URL: https://github.com/apache/incubator-doris/pull/10161#discussion_r897752510
##########
be/src/olap/in_list_predicate.cpp:
##########
@@ -132,15 +136,10 @@ IN_LIST_PRED_COLUMN_BLOCK_EVALUATE(NotInListPredicate, ==)
auto* nested_col_ptr = vectorized::check_and_get_column< \
vectorized::ColumnDictionary<vectorized::Int32>>(nested_col); \
auto& data_array = nested_col_ptr->get_data(); \
- std::vector<bool> selected; \
- nested_col_ptr->find_codes(_values, selected); \
for (uint16_t i = 0; i < *size; i++) { \
uint16_t idx = sel[i]; \
sel[new_size] = idx; \
- const auto& cell_value = data_array[idx]; \
- DCHECK(cell_value < (int64_t)selected.size()); \
- bool ret = !null_bitmap[idx] && (selected[cell_value] OP false); \
- new_size += _opposite ? !ret : ret; \
+ new_size += !null_bitmap[idx] && (_dict_codes[data_array[idx]]); \
Review Comment:
Why ignore `_opposite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org