You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2025/08/12 08:51:52 UTC
[PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
AlenkaF opened a new pull request, #47313:
URL: https://github.com/apache/arrow/pull/47313
### Rationale for this change
Ubuntu and Windows wheels started failing on free-threaded build of CPython 3.13 due to new cffi version 2.0.0, see https://cffi.readthedocs.io/en/latest/whatsnew.html#v2-0-0-dev0.
### What changes are included in this PR?
Pin CFFI in the Free-threaded 3.13 builds.
### Are these changes tested?
Yes, with the extended builds.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178898266
Revision: cc758f4d36e3fdc48c96a85bc82a77b1bbf0d15e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3c0c8c4c06](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3c0c8c4c06)
|Task|Status|
|----|------|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16907261778/job/47899827192)|
|wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16907261578/job/47899826670)|
|wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16907261587/job/47899826667)|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16907261664/job/47899826858)|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16907261690/job/47899826896)|
|wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16907261561/job/47899826702)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2303284367
##########
python/requirements-wheel-test-3.13t.txt:
##########
@@ -0,0 +1,19 @@
+cython
+hypothesis
+packaging
+pytest
+pytz
+pyuwsgi; sys.platform != 'win32' and python_version < '3.13'
+requests; sys_platform == 'win32'
+tzdata; sys_platform == 'win32'
+
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
Since this file is for 3.13, these lines can be simplified :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2303281048
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -37,16 +37,13 @@ ENV PYTHON_CMD="py -${python}t"
SHELL ["cmd", "/S", "/C"]
RUN %PYTHON_CMD% -m pip install -U pip setuptools
-COPY python/requirements-wheel-test.txt C:/arrow/python/
+COPY python/requirements-wheel-test-3.13t.txt C:/arrow/python/
Review Comment:
Or just open an issue for 3.14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178955132
Ah, I need to fix the Windows patch issue. Didn't saw that before: https://github.com/ursacomputing/crossbow/actions/runs/16905769938/job/47895087244#step:9:504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2271429226
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
Can we use Environment Markers https://packaging.python.org/en/latest/specifications/dependency-specifiers/#environment-markers instead of this approach? Something like:
```diff
--- a/python/requirements-test.txt
+++ b/python/requirements-test.txt
@@ -1,4 +1,5 @@
-cffi
+cffi; python_version != '3.13t'
+cffi<2.0.0; python_version == '3.13t'
hypothesis
packaging
pandas
```
(I'm not sure whether we have a variable to determine free-threaded CPython...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2281725694
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
It is surprising, yeah. In the examples shared patch versions are not used in the `python_version` Environment Marker. For example, [this issue](https://github.com/python/peps/issues/560) led me to believe that `python_version` only considers the major and minor versions.
As for the `t` suffix, I’m also not entirely sure about the background there. I vaguely remember hearing at EuroPython that it's going to stay, but I could be misremembering 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3180537042
@github-actions crossbow submit wheel-windows-cp310-cp310-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3179262392
Revision: 55dc4acfcb1f9decc6921276295ce745a90f03cf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b37f110292](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b37f110292)
|Task|Status|
|----|------|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16909763373/job/47908040397)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3182222011
I plan to:
- Update the PR to incorporate @kou’s comment for the requirements section.
- Work on the Windows Cython test failures in a separate PR, as I’m not making much progress here. I’ll also try setting up a VM to avoid using CI resources unnecessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3179242639
@github-actions crossbow submit wheel-windows-cp310-cp310-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3222900894
Revision: be6ca4c0ef397a6c09656b3dabf1d61ba33b6938
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f363f130ec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f363f130ec)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/17230669471/job/48883796433)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3222894230
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3290698921
No worries at all, just a minor PR needed. Thanks for all the work on your side!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3240972034
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3244201137
@pitrou mind having one last look before we merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2303332178
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -37,16 +37,13 @@ ENV PYTHON_CMD="py -${python}t"
SHELL ["cmd", "/S", "/C"]
RUN %PYTHON_CMD% -m pip install -U pip setuptools
-COPY python/requirements-wheel-test.txt C:/arrow/python/
+COPY python/requirements-wheel-test-3.13t.txt C:/arrow/python/
Review Comment:
I planned to open an issue for 3.14 - forgot to add in the comments!
Will do asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3182476115
Revision: 1df829dc9df119f53efe127c6dbd7e1ce229d4c0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f97fb926f3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f97fb926f3)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/16930331373/job/47974180274)|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16930331366/job/47974180252)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178693486
Revision: d853ccc9ba0371906bec98d56e2641a16f955199
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2685669349](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2685669349)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16905769938/job/47895087244)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178741136
The last commit fixes the build failures related to cffi and the CPython 3.13 version discrepancy.
I’m not sure if patching in the Dockerfile is the best approach, so I’m happy to change it if needed—cc @kou.
Now that the cffi failure is resolved, I’m continuing to investigate the Windows Cython failures (see https://github.com/apache/arrow/issues/47308). If I find a fix, I might add it here in the same PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3179035427
Revision: caa7067a6fa956364bc905b0c3d185c205c603bd
Submitted crossbow builds: [ursacomputing/crossbow @ actions-02fe533f65](https://github.com/ursacomputing/crossbow/branches/all?query=actions-02fe533f65)
|Task|Status|
|----|------|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16908239248/job/47902967200)|
|wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16908239245/job/47902967288)|
|wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16908239294/job/47902967507)|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16908239241/job/47902967215)|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16908239277/job/47902968617)|
|wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16908239123/job/47902967206)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "ngoldbaum (via GitHub)" <gi...@apache.org>.
ngoldbaum commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3285821303
Sorry the explicit lack of support for 3.13t in CFFI 2.0.0 caused you all a little headache here. Glad it was all sorted out eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178561209
Revision: d853ccc9ba0371906bec98d56e2641a16f955199
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5fc39b3bfa](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5fc39b3bfa)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/16904968416/job/47892500772)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178376156
Revision: fcd62fe215030e748ae65def07e68ebea69b6035
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4c2b829fab](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4c2b829fab)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16903952020/job/47889222806)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178368650
@github-actions crossbow submit wheel-windows-cp313-cp313t-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2272533883
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
Unfortunately, `python_version` doesn't support detailed versions like `3.13t` — it only handles the `major.minor` format:
```
Ignoring cffi: markers 'python_version == "3.13t"' don't match your environment
```
See: http://github.com/ursacomputing/crossbow/actions/runs/16930331373/job/47974180274
Other markers listed in [PEP 508](https://peps.python.org/pep-0508/#environment-markers) don't help either.
Using something like `os.environ.get("PYTHON_GIL")` in a requirements file is also ignored by pip, since arbitrary Python expressions aren’t supported in markers.
Not sure about other options — will keep investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2272533883
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
Unfortunately, `python_version` doesn't support detailed versions like `3.13t` — it only handles the `major.minor` format:
```
Ignoring cffi: markers 'python_version == "3.13t"' don't match your environment
```
See: https://github.com/ursacomputing/crossbow/actions/runs/16930331373/job/47974180274#step:6:722
Other markers listed in [PEP 508](https://peps.python.org/pep-0508/#environment-markers) don't help either.
Using something like `os.environ.get("PYTHON_GIL")` in a requirements file is also ignored by pip, since arbitrary Python expressions aren’t supported in markers.
Not sure about other options — will keep investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178686489
@github-actions crossbow submit wheel-windows-cp313-cp313t-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3197117167
> We should simply avoid installing cffi on `3.13t` (but not `3.14t` and later where it should be fine).
Agree. First, I need to find another option, since the current marker doesn't work anyway. After that, the setup will be adjusted to avoid installing cffi on `3.13t`.
I'm a bit busy this week, so feel free to jump in if anyone has ideas before I do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2303333467
##########
python/requirements-wheel-test-3.13t.txt:
##########
@@ -0,0 +1,19 @@
+cython
+hypothesis
+packaging
+pytest
+pytz
+pyuwsgi; sys.platform != 'win32' and python_version < '3.13'
+requests; sys_platform == 'win32'
+tzdata; sys_platform == 'win32'
+
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
Oh yes! Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2303383957
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -37,16 +37,13 @@ ENV PYTHON_CMD="py -${python}t"
SHELL ["cmd", "/S", "/C"]
RUN %PYTHON_CMD% -m pip install -U pip setuptools
-COPY python/requirements-wheel-test.txt C:/arrow/python/
+COPY python/requirements-wheel-test-3.13t.txt C:/arrow/python/
Review Comment:
Done: https://github.com/apache/arrow/issues/47437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3244187935
> Should we wait for the Windows wheels issue to be fixed so we can test the changes on `wheel-windows-cp313-cp313t-amd64` also?
I don't think we should, the Windows wheel issue is currently "blocked" by vcpkg issues and not being able to properly diagnose due to the lack of logs from vcpkg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2312970265
##########
python/requirements-wheel-test-3.13t.txt:
##########
@@ -0,0 +1,19 @@
+cython
+hypothesis
+packaging
+pytest
+pytz
+pyuwsgi; sys.platform != 'win32' and python_version < '3.13'
+requests; sys_platform == 'win32'
+tzdata; sys_platform == 'win32'
+
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
Done: https://github.com/apache/arrow/pull/47313/commits/430f26bc0ca01f68b770f1aede76aafd1060768d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178550293
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178367034
:warning: GitHub issue #47256 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3179028071
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3179846502
@github-actions crossbow submit wheel-windows-cp310-cp310-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2279919126
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
That's surprising that it only handles major and minor versions. I think the docs even show examples with a patch version?
https://packaging.python.org/en/latest/specifications/dependency-specifiers/#specification
I wonder if including a build number here would be helpful? I'm not sure that Python's packaging story is complete around the `t` suffix and how version comparisons are handled (my knowledge could also be outdated!)
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
That's surprising that it only handles major and minor versions. I think the docs even show examples with a patch version?
https://packaging.python.org/en/latest/specifications/dependency-specifiers/#specification
I wonder if including a patch number here would be helpful? I'm not sure that Python's packaging story is complete around the `t` suffix and how version comparisons are handled (my knowledge could also be outdated!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3227320198
@AlenkaF Can you update the PR title to reflect the PR contents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2299979017
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# cffi does not support free-threaded CPython 3.13
+# Remove next line with Python 3.14t!
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt
Review Comment:
Very well then =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3246129061
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 55be8c011cd9e82707382d97417b0c3a0aabf822.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/49426747139) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3242445353
Revision: c5c8e4e3a39038557cbd9bb709bac37821faf748
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ac6d583157](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ac6d583157)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/17379475979/job/49333316513)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #47313:
URL: https://github.com/apache/arrow/pull/47313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3242894201
Should we wait for the Windows wheels issue to be fixed so we can test the changes on `wheel-windows-cp313-cp313t-amd64` also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3222745732
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3222751094
Revision: a41c8ceac4367af402079839daa42f875a6520a7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-16df6ea1d6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-16df6ea1d6)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/17229500697/job/48880394266)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3222747236
I’ve decided to move back to patching requirements directly within the Dockerfiles for the free-threaded builds. If this approach will be accepted, I plan to create an issue for the Python 3.14 release (planned for October) to track the removal of the changes introduced in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3179859449
Revision: d9e53fd1786daf7a085c2054252c23b27c8b9d75
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1131ef4771](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1131ef4771)
|Task|Status|
|----|------|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16913464378/job/47921138703)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178384791
Revision: fcd62fe215030e748ae65def07e68ebea69b6035
Submitted crossbow builds: [ursacomputing/crossbow @ actions-860e036ce5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-860e036ce5)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/16904016411/job/47889437408)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3180543572
Revision: 4228c421ce036d96ea2eb947ec2dff1c1ddefac3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bee8b2d046](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bee8b2d046)
|Task|Status|
|----|------|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16917722632/job/47935755321)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178377662
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178502234
Installing `cffi` again with a pinned version won't help, as the first install from `requirements-*-test.txt` already triggers the failure.
Pinning `cffi` globally isn’t ideal since this only affects the 3.13 free-threaded build.
Instead, we can patch the requirements file directly in the Dockerfile to exclude `cffi` and re-add it with a pinned version (`<2.0.0`). This avoids maintaining a separate override file and keeps the change localized to the affected build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3178891058
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3196325103
The fix here doesn't really make sense, because cffi versions before 2.0.0 have never supported free-threading (they would simply crash at runtime).
For the record, the reasons for not supporting free-threaded 3.13 in cffi are stated [here](https://github.com/python-cffi/cffi/pull/178#issuecomment-3117912171).
We should simply avoid installing cffi on `3.13t` (but not `3.14t` and later where it should be fine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2272103053
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt && \
+ echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt
Review Comment:
Oh, that is much much nicer! Thank you @kou .
I noticed a use of `PYTHON_GIL` in the free-threaded builds. Looking at [python-wheels/github.osx.yml](https://github.com/apache/arrow/blob/0ae71f81d56bfac1968956304e965790510bfa7c/dev/tasks/python-wheels/github.osx.yml#L30) it seems same as what you suggested in this diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds and use newer Win SDK in Windows wheels [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3182467320
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading wheel-windows-cp313-cp313t-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3240976398
Revision: 430f26bc0ca01f68b770f1aede76aafd1060768d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c0a94d79aa](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c0a94d79aa)
|Task|Status|
|----|------|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/17369140876/job/49301242062)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47313:
URL: https://github.com/apache/arrow/pull/47313#issuecomment-3242438232
@github-actions crossbow submit test-ubuntu-22.04-python-313-freethreading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2299937628
##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
ENV ARROW_PYTHON_VENV /arrow-dev
RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# cffi does not support free-threaded CPython 3.13
+# Remove next line with Python 3.14t!
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > /arrow/python/requirements-patched.txt
Review Comment:
I would favor a separate `requirements-test-3.13t.txt` instead of this hack :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47256: [Python] Pin cffi in free-threaded builds [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2303265992
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -37,16 +37,13 @@ ENV PYTHON_CMD="py -${python}t"
SHELL ["cmd", "/S", "/C"]
RUN %PYTHON_CMD% -m pip install -U pip setuptools
-COPY python/requirements-wheel-test.txt C:/arrow/python/
+COPY python/requirements-wheel-test-3.13t.txt C:/arrow/python/
Review Comment:
Python 3.14 is going to be released around the next Arrow release (2025-10-07), we might want to add wheels for Arrow 22.
Can you add a comment here to revisit for Python 3.14? We will probably have to make this conditional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org