You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by hzbarcea <gi...@git.apache.org> on 2015/07/19 00:00:34 UTC
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
GitHub user hzbarcea opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/758
License files are not needed for tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzbarcea/incubator-brooklyn no-test-lic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #758
----
commit c824dad07da2876561f08c6bff6bb940fe74bf7e
Author: Hadrian Zbarcea <ha...@apache.org>
Date: 2015-07-18T18:57:22Z
License files are not needed for tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/758#issuecomment-124082884
Before this can be merged we need to confirm that the boilerplate mechanism is still adding LICENSE/NOTICE/DISCLAIMER to the Maven `-test.jar` artifact. (I'll try and check this later)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/758#issuecomment-126509644
@rdowner , thanks for the review. I agree with your statement that the notices are required in the -test jars. Consolidation is needed though. I will revisit my PR, looks like it's not that simple. I will close this one for now and come back with a better solution later. I think there are a couple of comments from the release vote on general@ that should be addressed. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/758#issuecomment-124056842
+1, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
Posted by CMoH <gi...@git.apache.org>.
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/758#issuecomment-122823728
Only affects text files. Looks good for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License files are not needed for ...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/758#issuecomment-126488872
We **do** need `LICENSE`/`NOTICE`/`DISCLAIMER` for tests, as the test artifacts are released by the project and published to Maven. This PR causes these files to be missing from the test artifact, against Apache release policy.
Because the "main" parts of these two projects require custom LICENSE files to account for bundled dependencies, the module's pom.xml disables maven-remote-resources-plugin to stop it copying the boilerplate files, and instead we supply our own files. However we're not able to disable the plugin for "main" and enable it for "test" - we have to disable it for both - therefore we also need to add `LICENSE`/`NOTICE`/`DISCLAIMER` for "test", even though in this case it's just the unmodified Apache version of these files.
For the remaining projects, they do not have `LICENSE`/`NOTICE`/`DISCLAIMER` in the source code, but maven-remote-resources-plugin automatically installs those files into artifacts (main and test) so they do not appear in the source folders.
See commit 430fb33 to see how this change was made.
(Apologies it's taken so long to review this.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---