You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/02/12 21:07:00 UTC

[jira] [Created] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

Ted Yu created HBASE-19985:
------------------------------

             Summary: Redundant instanceof check in ProtobufUtil#getServiceException
                 Key: HBASE-19985
                 URL: https://issues.apache.org/jira/browse/HBASE-19985
             Project: HBase
          Issue Type: Bug
    Affects Versions: 1.4.1
            Reporter: Ted Yu


{code}
  public static IOException getServiceException(ServiceException e) {
    Throwable t = e;
    if (e instanceof ServiceException) {
      t = e.getCause();
{code}
The instanceof check would always return true.

This was reported by https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)