You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by "Adam Antal (Jira)" <ji...@apache.org> on 2019/12/04 10:40:00 UTC
[jira] [Commented] (SUBMARINE-49) Add more test coverage to
RunJobParameters
[ https://issues.apache.org/jira/browse/SUBMARINE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987731#comment-16987731 ]
Adam Antal commented on SUBMARINE-49:
-------------------------------------
As discussed in the PR, the module will be refactored, so it does not make sense to push this in before that. After the refactor, the issue will probably be obsolete.
> Add more test coverage to RunJobParameters
> ------------------------------------------
>
> Key: SUBMARINE-49
> URL: https://issues.apache.org/jira/browse/SUBMARINE-49
> Project: Apache Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Adam Antal
> Priority: Major
> Labels: pull-request-available
> Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch, SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch, SUBMARINE-49.005.patch, SUBMARINE-49.006.patch, SUBMARINE-49.007.patch, SUBMARINE-49.007.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There are some good tests in {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but these are not testing all fields set by method {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}.
> Some more extensive testing is needed in this area.
> As an added bonus, the code {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}} could be cleaned up a bit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org