You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "jrsteinebrey (via GitHub)" <gi...@apache.org> on 2025/08/14 19:37:29 UTC
[PR] NIFI-14732 Delete references to removed encrypted repo classes [nifi]
jrsteinebrey opened a new pull request, #10207:
URL: https://github.com/apache/nifi/pull/10207
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
NIFI-14732 Delete references to removed classes:
EncryptedSequentialAccessWriteAheadLog
EncryptedWriteAheadProvenanceRepository
# Summary
[NIFI-14732](https://issues.apache.org/jira/browse/NIFI-14732)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-14732) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-14732`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-14732`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Ran the NiFi service locally and ran a data flow.
### Build
- [X] Build completed using `./mvnw clean install -P contrib-check`
- [X] JDK 21
### Licensing
No changes
### Documentation
- [X] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14732 Delete references to removed encrypted repo classes [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10207:
URL: https://github.com/apache/nifi/pull/10207#discussion_r2279010781
##########
nifi-docs/src/main/asciidoc/administration-guide.adoc:
##########
@@ -2951,7 +2951,7 @@ Write-Ahead Log should be used. The default value is `org.apache.nifi.wali.Seque
in order to address an issue that exists in the older implementation. In the event of power loss or an operating system crash, the old implementation was susceptible to recovering FlowFiles
incorrectly. This could potentially lead to the wrong attributes or content being assigned to a FlowFile upon restart, following the power loss or OS crash. However, one can still choose to opt into
using the previous implementation and accept that risk, if desired (for example, if the new implementation were to exhibit some unexpected error).
-To do so, set the value of this property to `org.wali.MinimalLockingWriteAheadLog`. Another available implementation is `org.apache.nifi.wali.EncryptedSequentialAccessWriteAheadLog`.
+To do so, set the value of this property to `org.wali.MinimalLockingWriteAheadLog`.
Review Comment:
This entire property description can now be removed since there are no other implementations
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java:
##########
@@ -202,15 +191,8 @@ public void initialize(final ResourceClaimManager claimManager, final Repository
// delete backup. On restore, if no files exist in partition's directory, would have to check backup directory
this.serdeFactory = serdeFactory;
- // The specified implementation can be plaintext or encrypted; the only difference is the serde factory
- if (walImplementation.equals(SEQUENTIAL_ACCESS_WAL) || walImplementation.equals(ENCRYPTED_SEQUENTIAL_ACCESS_WAL)) {
- // TODO: May need to instantiate ESAWAL for clarity?
- wal = new SequentialAccessWriteAheadLog<>(flowFileRepositoryPaths.get(0), serdeFactory, this);
- } else {
- throw new IllegalStateException("Cannot create Write-Ahead Log because the configured property '" + NiFiProperties.FLOWFILE_REPOSITORY_WAL_IMPLEMENTATION +
- "' has an invalid value of '" + walImplementation + "'. Please update nifi.properties to indicate a valid value for this property.");
- }
-
+ // TODO: May need to instantiate ESAWAL for clarity?
Review Comment:
The `TODO` comment no longer applies, it was referring to the encrypted implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14732 Delete references to removed encrypted repo classes [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #10207:
URL: https://github.com/apache/nifi/pull/10207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14732 Delete references to removed encrypted repo classes [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #10207:
URL: https://github.com/apache/nifi/pull/10207#discussion_r2277698654
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java:
##########
@@ -202,13 +201,12 @@ public void initialize(final ResourceClaimManager claimManager, final Repository
// delete backup. On restore, if no files exist in partition's directory, would have to check backup directory
this.serdeFactory = serdeFactory;
- // The specified implementation can be plaintext or encrypted; the only difference is the serde factory
- if (walImplementation.equals(SEQUENTIAL_ACCESS_WAL) || walImplementation.equals(ENCRYPTED_SEQUENTIAL_ACCESS_WAL)) {
+ try {
// TODO: May need to instantiate ESAWAL for clarity?
wal = new SequentialAccessWriteAheadLog<>(flowFileRepositoryPaths.get(0), serdeFactory, this);
- } else {
+ } catch (final Exception ex) {
Review Comment:
This `catch` seems unnecessary because there is only one implementation of the Write-Ahead Log supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org