You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/25 10:14:30 UTC
[GitHub] [doris] starocean999 opened a new pull request, #11182: always copy data to agg status
starocean999 opened a new pull request, #11182:
URL: https://github.com/apache/doris/pull/11182
# Proposed changes
Issue Number: close (https://github.com/apache/doris/issues/11115)
## Problem Summary:
The agg data should always be copided instead of keep a column ptr + row pos. Because the column may be freed later, the agg data would have an invalid ptr.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #11182: always copy data to agg status
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #11182:
URL: https://github.com/apache/doris/pull/11182#issuecomment-1193933709
It looks like this pr modifies the behavior of the `load`/`window function`/`reader` related functions.
I only see errors about `load` and `window functions` in #11115, Then maybe we shouldn't change the `reader` related function behavior.
@HappenLee @zhangstar333 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei closed pull request #11182: always copy data to agg status
Posted by GitBox <gi...@apache.org>.
yiguolei closed pull request #11182: always copy data to agg status
URL: https://github.com/apache/doris/pull/11182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org