You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/06/06 11:22:29 UTC

Review Request 59836: LENS-1434: Segmentation Candidate should have dynamic cost depending on facts picked in segmented cubes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59836/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1434
    https://issues.apache.org/jira/browse/LENS-1434


Repository: lens


Description
-------

Currently weight is fixed.


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 0855ced92ebe0ab31056e4a9570f8b2edd0d6733 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java d064cdb31a56010c1541dfdfbb22dfe0afe0c1d1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java c4049cdcb29fb12a888ee65da2c4f9422348b110 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java dd25f3e2bffa8c8a8dad84b068343c9b6575a384 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a359d86d26d6377c2860e7f90ed05e33f4d76507 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 3f5e2e56eca26bb8a36107a4695679e216dabec5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java c5351965a3e3966fad04e35ea84c119ac78de88d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 757a877034e4ab824c3c77c7045d5300dc2d19f6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 9412f274d64de26b9f37619eb74ecee1ef9e94d4 


Diff: https://reviews.apache.org/r/59836/diff/1/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 59836: LENS-1434: Segmentation Candidate should have dynamic cost depending on facts picked in segmented cubes

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59836/#review177026
-----------------------------------------------------------


Ship it!




Ship It!

- Puneet Gupta


On June 6, 2017, 12:31 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59836/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 12:31 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1434
>     https://issues.apache.org/jira/browse/LENS-1434
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Currently weight is fixed.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 0855ced92ebe0ab31056e4a9570f8b2edd0d6733 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java d064cdb31a56010c1541dfdfbb22dfe0afe0c1d1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java c4049cdcb29fb12a888ee65da2c4f9422348b110 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java dd25f3e2bffa8c8a8dad84b068343c9b6575a384 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a359d86d26d6377c2860e7f90ed05e33f4d76507 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 79807977e9dbb52a04fb80dc1176874772b3cc2f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java c5351965a3e3966fad04e35ea84c119ac78de88d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 757a877034e4ab824c3c77c7045d5300dc2d19f6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 9412f274d64de26b9f37619eb74ecee1ef9e94d4 
> 
> 
> Diff: https://reviews.apache.org/r/59836/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 59836: LENS-1434: Segmentation Candidate should have dynamic cost depending on facts picked in segmented cubes

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59836/
-----------------------------------------------------------

(Updated June 6, 2017, 6:01 p.m.)


Review request for lens.


Bugs: LENS-1434
    https://issues.apache.org/jira/browse/LENS-1434


Repository: lens


Description
-------

Currently weight is fixed.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 0855ced92ebe0ab31056e4a9570f8b2edd0d6733 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java d064cdb31a56010c1541dfdfbb22dfe0afe0c1d1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java c4049cdcb29fb12a888ee65da2c4f9422348b110 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java dd25f3e2bffa8c8a8dad84b068343c9b6575a384 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a359d86d26d6377c2860e7f90ed05e33f4d76507 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 79807977e9dbb52a04fb80dc1176874772b3cc2f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java c5351965a3e3966fad04e35ea84c119ac78de88d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 757a877034e4ab824c3c77c7045d5300dc2d19f6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 9412f274d64de26b9f37619eb74ecee1ef9e94d4 


Diff: https://reviews.apache.org/r/59836/diff/3/

Changes: https://reviews.apache.org/r/59836/diff/2-3/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 59836: LENS-1434: Segmentation Candidate should have dynamic cost depending on facts picked in segmented cubes

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59836/
-----------------------------------------------------------

(Updated June 6, 2017, 5:21 p.m.)


Review request for lens.


Bugs: LENS-1434
    https://issues.apache.org/jira/browse/LENS-1434


Repository: lens


Description
-------

Currently weight is fixed.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 0855ced92ebe0ab31056e4a9570f8b2edd0d6733 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java d064cdb31a56010c1541dfdfbb22dfe0afe0c1d1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f38aa549caaf113ae70accdb2ede8fcc23e1fc47 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java c4049cdcb29fb12a888ee65da2c4f9422348b110 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java dd25f3e2bffa8c8a8dad84b068343c9b6575a384 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a359d86d26d6377c2860e7f90ed05e33f4d76507 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 3f5e2e56eca26bb8a36107a4695679e216dabec5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java c5351965a3e3966fad04e35ea84c119ac78de88d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 757a877034e4ab824c3c77c7045d5300dc2d19f6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 9412f274d64de26b9f37619eb74ecee1ef9e94d4 


Diff: https://reviews.apache.org/r/59836/diff/2/

Changes: https://reviews.apache.org/r/59836/diff/1-2/


Testing
-------


Thanks,

Rajat Khandelwal