[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8870: Additional Kinesis resharding fixes

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8870: Additional Kinesis resharding fixes
URL: https://github.com/apache/incubator-druid/pull/8870#discussion_r351526438
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/BaseAppenderatorDriver.java
 ##########
 @@ -551,10 +551,19 @@ protected AppenderatorDriverAddResult append(
   )
   {
     if (segmentsAndMetadata.getSegments().isEmpty()) {
-      log.debug("Nothing to publish, skipping publish step.");
-      final SettableFuture<SegmentsAndMetadata> retVal = SettableFuture.create();
-      retVal.set(segmentsAndMetadata);
-      return retVal;
+      if (!publisher.supportsEmptyPublish()) {
+        log.info("Nothing to publish, skipping publish step.");
+        final SettableFuture<SegmentsAndMetadata> retVal = SettableFuture.create();
+        retVal.set(segmentsAndMetadata);
+        return retVal;
+      } else {
+        if (appenderator.getTotalRowCount() != 0) {
 
 Review comment:
   could you leave a comment explaining the purpose of this check being in the else case, and explain why it isn't always an error?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org