You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2015/11/26 13:15:58 UTC

Review Request 40742: Ambari Views : each view should have separate log file for better troubleshooting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40742/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.


Bugs: AMBARI-14084
    https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
-------

Earlier : 
Logs of all the views goes into the same file where ambari logs also go i.e. in ambari-server.log file

After Patch : 
There will be separate log files for each views.

In the patch : 
changes in log4j.properties.
Created separate appenders for each view.
Loggers for each view with separate package name.
set additivity of loggers to false so that logs are not duplicated into ambari-server.log


Diffs
-----

  ambari-server/conf/unix/log4j.properties c87b1f4 
  ambari-server/conf/windows/log4j.properties 8a69508 

Diff: https://reviews.apache.org/r/40742/diff/


Testing
-------

Manual testing done to look if each view is generating logs in their own log file.


Thanks,

Nitiraj Rathore


Re: Review Request 40742: Ambari Views : each view should have separate log file for better troubleshooting

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40742/#review112198
-----------------------------------------------------------

Ship it!


Ship It!

- Matt


On Nov. 26, 2015, 4:15 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40742/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 4:15 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-14084
>     https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Earlier : 
> Logs of all the views goes into the same file where ambari logs also go i.e. in ambari-server.log file
> 
> After Patch : 
> There will be separate log files for each views.
> 
> In the patch : 
> changes in log4j.properties.
> Created separate appenders for each view.
> Loggers for each view with separate package name.
> set additivity of loggers to false so that logs are not duplicated into ambari-server.log
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/log4j.properties c87b1f4 
>   ambari-server/conf/windows/log4j.properties 8a69508 
> 
> Diff: https://reviews.apache.org/r/40742/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done to look if each view is generating logs in their own log file.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 40742: Ambari Views : each view should have separate log file for better troubleshooting

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40742/#review112229
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Nov. 26, 2015, 12:15 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40742/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 12:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-14084
>     https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Earlier : 
> Logs of all the views goes into the same file where ambari logs also go i.e. in ambari-server.log file
> 
> After Patch : 
> There will be separate log files for each views.
> 
> In the patch : 
> changes in log4j.properties.
> Created separate appenders for each view.
> Loggers for each view with separate package name.
> set additivity of loggers to false so that logs are not duplicated into ambari-server.log
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/log4j.properties c87b1f4 
>   ambari-server/conf/windows/log4j.properties 8a69508 
> 
> Diff: https://reviews.apache.org/r/40742/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done to look if each view is generating logs in their own log file.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>