You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/06 00:11:58 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
nsivabalan opened a new pull request #4518:
URL: https://github.com/apache/hudi/pull/4518
## What is the purpose of the pull request
Restore means rollback of N no of commits.And so, we don't publish rollback instants to timeline only during restore. but sometime back we added rollback plan to rollback requested instant and hence publishing them is unavoidable. But we missed to clean up the rollback meta files at the end of restore. this patch fixes it by cleaning up the rollback meta files from the timeline after restore is complete.
## Brief change log
After finishing restore, delete all rollback instants from timeline generated as part of the restore.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
codope merged pull request #4518:
URL: https://github.com/apache/hudi/pull/4518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1006204405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1008222910
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
}, {
"hash" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5022",
"triggerID" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
* 108b27f73f4656423be54bf4b20ba9dad8a26647 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1008222649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
}, {
"hash" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
* 108b27f73f4656423be54bf4b20ba9dad8a26647 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1008222649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
}, {
"hash" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
* 108b27f73f4656423be54bf4b20ba9dad8a26647 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1006180338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1008228966
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
}, {
"hash" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5022",
"triggerID" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 108b27f73f4656423be54bf4b20ba9dad8a26647 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1006181779
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1006181779
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1008222910
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
}, {
"hash" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5022",
"triggerID" : "108b27f73f4656423be54bf4b20ba9dad8a26647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
* 108b27f73f4656423be54bf4b20ba9dad8a26647 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1006204405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4921)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4518: [HUDI-2477] Removing rollbacks instants from timeline for restore operation
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4518:
URL: https://github.com/apache/hudi/pull/4518#issuecomment-1006180338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b82de3c867cddb3af7f2edd7f48f662defda372",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b82de3c867cddb3af7f2edd7f48f662defda372 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org