[GitHub] [hive] deniskuzZ commented on a diff in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r841497550


##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
   3: required string tableName,
   4: required list<string> partVals,
   5: required Partition newPart,
-  6: optional string validWriteIdList
+  6: optional string validWriteIdList,
+  7: optional EnvironmentContext environmentContext

Review Comment:
   RenamePartitionRequest is only used by thrift to pass the data, however, it's not used by the server-side. All its internals are extracted into individual params including `EnvironmentContext`.
   HMSHandler.alterPartitionForTruncate, HiveAlterHandler.alterPartition do not operate on request object, but individual params. 
   If we want to use RenamePartitionRequest that would require a major refactor. Currently, if I would simply extend RenamePartitionRequest with `txnid` and`RENAME_MAKE_DATA_COPY` I would still need to pass them through the `EnvironmentContext` on a server-side. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org