You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/02/22 17:37:35 UTC
[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1887
ARTEMIS-1696 allow empty 'address' for grouping-handler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1696
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1887.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1887
----
commit 7b7af3519c4113124dcd04ce6922d37b61f3069f
Author: Justin Bertram <jb...@...>
Date: 2018-02-22T17:29:13Z
ARTEMIS-1696 allow empty 'address' for grouping-handler
----
---
[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1887
---
[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1887#discussion_r170118840
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ---
@@ -1671,7 +1671,7 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur
private void parseGroupingHandlerConfiguration(final Element node, final Configuration mainConfiguration) {
String name = node.getAttribute("name");
String type = getString(node, "type", null, Validators.NOT_NULL_OR_EMPTY);
- String address = getString(node, "address", null, Validators.NOT_NULL_OR_EMPTY);
+ String address = getString(node, "address", "", Validators.NO_CHECK);
--- End diff --
why "" for default not Null now you're removing the NOT NULL OR EMPTY check?
---
[GitHub] activemq-artemis issue #1887: ARTEMIS-1696 allow empty 'address' for groupin...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1887
as no further comments, and @jbertram answered my query from the other day, merging.
---
[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1887#discussion_r170153460
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ---
@@ -1671,7 +1671,7 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur
private void parseGroupingHandlerConfiguration(final Element node, final Configuration mainConfiguration) {
String name = node.getAttribute("name");
String type = getString(node, "type", null, Validators.NOT_NULL_OR_EMPTY);
- String address = getString(node, "address", null, Validators.NOT_NULL_OR_EMPTY);
+ String address = getString(node, "address", "", Validators.NO_CHECK);
--- End diff --
I did that to match the change that was made for the cluster-connection address parsing. See https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java#L1581.
---