[GitHub] [tvm] echuraev commented on a diff in pull request #14707: [Keras][Bugfix] fix a bug about alpha attribute in LeakyReLU which lead to passes conflict

["echuraev (via GitHub)" <gi...@apache.org>]

echuraev commented on code in PR #14707:
URL: https://github.com/apache/tvm/pull/14707#discussion_r1174878416


##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -209,6 +211,15 @@ def test_forward_activations(self, keras_mod):
             keras_model = keras_mod.models.Model(data, x)
             verify_keras_frontend(keras_model)
             verify_keras_frontend(keras_model, need_transpose=False, layout="NHWC")
+        # test invalid attribute alpha=None for LeakyReLU
+        if package_version.parse(keras_mod.__version__.split("-tf")[0]) <= package_version.parse(
+            "2.3.1"
+        ):

Review Comment:
   Why do you need such check on the package version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org