You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/16 13:14:00 UTC

[jira] [Commented] (MAPREDUCE-6940) Copy-paste error in the TaskAttemptUnsuccessfulCompletionEvent constructor

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128773#comment-16128773 ] 

ASF GitHub Bot commented on MAPREDUCE-6940:
-------------------------------------------

GitHub user dosoft opened a pull request:

    https://github.com/apache/hadoop/pull/263

    MAPREDUCE-6940: Pass allSplits parameter

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dosoft/hadoop MAPREDUCE-6940

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit 045f1f5bc0aa65c6d19a1411c631ecb2d61659a4
Author: Oleg Danilov <ol...@olegd.com>
Date:   2017-08-16T13:09:54Z

    MAPREDUCE-6940: Pass allSplits parameter

----


> Copy-paste error in the TaskAttemptUnsuccessfulCompletionEvent constructor
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6940
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6940
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Priority: Minor
>
> This constructor seems to be copy-pasted from another one, but it doesn't pass allSplits parameter as expected.
> Lines 126-133:
> {code:java}
>   public TaskAttemptUnsuccessfulCompletionEvent
>       (TaskAttemptID id, TaskType taskType,
>        String status, long finishTime,
>        String hostname, int port, String rackName,
>        String error, int[][] allSplits) {
>     this(id, taskType, status, finishTime, hostname, port,
>         rackName, error, EMPTY_COUNTERS, null);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org