You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/05 22:38:28 UTC
Review Request 35152: Document and consolidate qdisc handles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Document and consolidate qdisc handles
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review86867
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35150, 35152]
All tests passed.
- Mesos ReviewBot
On June 5, 2015, 10:35 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 10:35 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review86856
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138965>
Somewhere we should mention icmp and arp are mirrored, but ip traffic is redirected, which takes precedence than the former two in filtering.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138961>
Should be more clear that this is inside the container.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138969>
"reduce performance interference" seems a bit too general to me. Can we touch a bit on the specifics such as "each container's outbound traffic is given a separate flow, and also the catch-all flow for traffic originated from host and everything else", etc
- Chi Zhang
On June 5, 2015, 10:35 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 10:35 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review87049
-----------------------------------------------------------
Ship it!
Nice comments! Please adjust the comments as I suggested. We can chat if you don't understand what I was talking about.
Otherwise, LGTM!
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139311>
for [7] and [10], I would move the arrow at [7] to veth0
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139312>
For [8] and [9], I would use a double ended arrow <--> and move the arrow at [8] to mesosNNNN.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139309>
Kill this line.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139308>
2 lines above
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139310>
Please adjust the format. Notice that there is a 'script' in the end.
- Jie Yu
On June 8, 2015, 4:35 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 4:35 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
-----------------------------------------------------------
(Updated June 8, 2015, 6:47 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
Address reviewer comments.
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Document and consolidate qdisc handles
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
-----------------------------------------------------------
(Updated June 8, 2015, 4:35 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
Incorporate review comments.
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Document and consolidate qdisc handles
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review86870
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138998>
s/data/packet/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139002>
s/filter/class/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139004>
s/CLASS_ID/HTB_CLASS_ID/ ?
- Cong Wang
On June 5, 2015, 11:55 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 11:55 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review86873
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139003>
... and filters
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment139005>
This is not correct. lo(s) do not talk to each other.
- Jie Yu
On June 5, 2015, 11:55 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 11:55 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
-----------------------------------------------------------
(Updated June 5, 2015, 11:55 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
Address reviewers comments
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Document and consolidate qdisc handles
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/
-----------------------------------------------------------
(Updated June 5, 2015, 10:35 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
Incorporate review comments.
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Document and consolidate qdisc handles
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review86847
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35150, 35152]
All tests passed.
- Mesos ReviewBot
On June 5, 2015, 8:38 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:38 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35152: Document and consolidate qdisc handles
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152/#review86843
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138941>
s/connection/interface/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138939>
s/data/packet/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138940>
s/policies/filters/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138937>
s/interface qdisc/qdisc/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138938>
Nit: there could be more than one filters since we could have more than one port ranges for each container.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138931>
What is "filter chain"?? There is no such thing in TC. Also we don't have any filter on htb.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138932>
Ditto, there is no filter here, just a class.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138933>
The fq_codel qdisc here is for reducing buffer-bloat, not traffic shaping.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138934>
s/FInally/Finally/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35152/#comment138935>
Ditto, the fq_codel here is for traffic isolation and reducing buffer-bloat.
- Cong Wang
On June 5, 2015, 8:38 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35152/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:38 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document and consolidate qdisc handles
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191
>
> Diff: https://reviews.apache.org/r/35152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>