[GitHub] [lucene-solr] gerlowskija commented on issue #1068: SOLR-14033: Fix Hadoop tests with security manager

[GitBox <gi...@apache.org>]

gerlowskija commented on issue #1068: SOLR-14033: Fix Hadoop tests with security manager
URL: https://github.com/apache/lucene-solr/pull/1068#issuecomment-564179891
 
 
   The duplication of the Hadoop Java files here seems ugly, though I'm sure you're only doing it because there's no other recourse : (
   
   Is it worth putting some sort of header or class-level comment on all these copied-over files to indicate that they were copied verbatim from whatever particular hadoop package?  Or alternatively maybe we should have a comment in ant/ivy where we declare our Hadoop dependency that all these files should be updated whenever we change our hadoop version?
   
   I'm running tests now and will post later when they're done as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org