[GitHub] [superset] AAfghahi commented on a diff in pull request #21893: feat: Add dataset visuals for when a table is selected

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #21893:
URL: https://github.com/apache/superset/pull/21893#discussion_r1001112692


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx:
##########
@@ -65,6 +65,9 @@ export function datasetReducer(
   }
 }
 
+const prevUrl =

Review Comment:
   this is still temporary?



##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/index.tsx:
##########
@@ -44,12 +74,29 @@ const renderDescription = () => (
   </>
 );
 
-export default function DatasetPanel() {
-  return (
+const DatasetPanel = ({ tableName }: DatasetPanelProps) =>
+  tableName ? (
+    <StyledDatasetPanel>
+      <div className="table-name">
+        <Icons.Table iconColor={supersetTheme.colors.grayscale.base} />
+        {tableName}
+        <RefreshLabel
+          onClick={() => {
+            console.log(

Review Comment:
   is this console log necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org