You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/01/11 11:48:36 UTC
Review Request 55418: AMBARI-19454. Label changes and missing fields
for action nodes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55418/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19454
https://issues.apache.org/jira/browse/AMBARI-19454
Repository: ambari
Description
-------
Need below label changes for below action nodes :
1) Spark :
a) 'Job Tracker' should be changed to 'Resource Manager'
b) Change the 'Name' to 'Application Name'
c) 'Mode' field which is part of the xsd is missing.
2) Java :
a) Java opts to 'java Options'
b) Provide hidden label for 'Java opt' input field. (Required for automation)
3) Email :
a) 'Content Type' and 'Attachment' fields missing in email node
4) SSH
a) Provide label for 'args' radio group.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2
Diff: https://reviews.apache.org/r/55418/diff/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 55418: AMBARI-19454. Label changes and missing
fields for action nodes
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55418/#review161230
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 11, 2017, 12:28 p.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55418/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 12:28 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19454
> https://issues.apache.org/jira/browse/AMBARI-19454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need below label changes for below action nodes :
> 1) Spark :
> a) 'Job Tracker' should be changed to 'Resource Manager'
> b) Change the 'Name' to 'Application Name'
> 2) Java :
> a) Java opts to 'java Options'
> b) Provide hidden label for 'Java opt' input field. (Required for automation)
> 4) SSH
> a) Provide label for 'args' radio group.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2
>
> Diff: https://reviews.apache.org/r/55418/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 55418: AMBARI-19454. Label changes and missing
fields for action nodes
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55418/#review161219
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Jan. 11, 2017, 12:28 p.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55418/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 12:28 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19454
> https://issues.apache.org/jira/browse/AMBARI-19454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need below label changes for below action nodes :
> 1) Spark :
> a) 'Job Tracker' should be changed to 'Resource Manager'
> b) Change the 'Name' to 'Application Name'
> 2) Java :
> a) Java opts to 'java Options'
> b) Provide hidden label for 'Java opt' input field. (Required for automation)
> 4) SSH
> a) Provide label for 'args' radio group.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2
>
> Diff: https://reviews.apache.org/r/55418/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 55418: AMBARI-19454. Label changes and missing
fields for action nodes
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55418/#review161227
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 11, 2017, 12:28 p.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55418/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 12:28 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19454
> https://issues.apache.org/jira/browse/AMBARI-19454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need below label changes for below action nodes :
> 1) Spark :
> a) 'Job Tracker' should be changed to 'Resource Manager'
> b) Change the 'Name' to 'Application Name'
> 2) Java :
> a) Java opts to 'java Options'
> b) Provide hidden label for 'Java opt' input field. (Required for automation)
> 4) SSH
> a) Provide label for 'args' radio group.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2
>
> Diff: https://reviews.apache.org/r/55418/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 55418: AMBARI-19454. Label changes and missing
fields for action nodes
Posted by Madhan Reddy <mr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55418/
-----------------------------------------------------------
(Updated Jan. 11, 2017, 12:28 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19454
https://issues.apache.org/jira/browse/AMBARI-19454
Repository: ambari
Description (updated)
-------
Need below label changes for below action nodes :
1) Spark :
a) 'Job Tracker' should be changed to 'Resource Manager'
b) Change the 'Name' to 'Application Name'
2) Java :
a) Java opts to 'java Options'
b) Provide hidden label for 'Java opt' input field. (Required for automation)
4) SSH
a) Provide label for 'args' radio group.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2
Diff: https://reviews.apache.org/r/55418/diff/
Testing
-------
Manual
Thanks,
Madhan Reddy