[GitHub] [incubator-druid] jon-wei opened a new pull request #9059: Fix hadoop ingestion property handling when using indexers

[GitBox <gi...@apache.org>]

jon-wei opened a new pull request #9059: Fix hadoop ingestion property handling when using indexers
URL: https://github.com/apache/incubator-druid/pull/9059
 
 
   Fixes #8840.
   
   ### Description
   
   This PR fixes an issue where the map/reduce jobs created by a HadoopIndexTask running inside an Indexer process didn't pick up configuration properties that were specified in Druid's config files.
   
   Hadoop tasks running in an Indexer process need a reference to the Properties instance created
   in PropertiesModule so that the task sees properties that were specified in Druid's config files.
   
   Peon-based tasks didn't have this issue since they have all properties, including config file properties, specified on their command line by ForkingTaskRunner (so they could use System.getProperties() only).
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org