[GitHub] cordova-plugin-vibration pull request: Cb 7138

[eymorale <gi...@git.apache.org>]

GitHub user eymorale opened a pull request:

    https://github.com/apache/cordova-plugin-vibration/pull/17

    Cb 7138

    Added more test cases for old vibration calls and added test cases for new vibration calls that align with w3c spec

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eymorale/cordova-plugin-vibration CB-7138

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-vibration/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 53760ccbf19964d20e9a6693cb1f52050f2c5391
Author: Martin Gonzalez <ma...@gmail.com>
Date:   2014-07-15T20:33:20Z

    CB-6963, ported vibration automated & manual tests
    
    Ported tests from mobilespec.
    
    Jasmine version: ported from v1.3 to v2.0

commit d677a1e7e72c284e3a07dbe90370cc20213b0f61
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-15T20:54:51Z

    Merged current tests to add new tests

commit c1a88b20c06ffbde802b488609412da366d4fe2a
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-16T20:12:29Z

    added tests to ensure compliance with w3c spec

commit c226b6df96ee44770586de5922ec72ae434c6ba5
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-16T20:34:28Z

    added 'Android only' to buttons for specific tests, changed where console.log is executed for user to see earlier

commit e0723e2973866289357ec75f473ca4f0c467bb6d
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-18T13:46:24Z

    added tests for old vibrateWithPattern and cancelVibration calls

commit 90c6335c59775fb5ee94ccf8aa027e5bfc98e9fd
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-18T19:02:34Z

    on/off button for cancel tests, add results box and msgs

commit 5ce57fc08d513e798052f4aeb992e2752980ba03
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-21T12:57:14Z

    add setTimeout function to update vibrateOn var if user doesn't cancel vibrate, add note about iOS

commit 4b01432cf26ffbce13feba58bf5b10d16d45ffaf
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-21T13:42:51Z

    clear settimeout when user cancels vibration

commit d93aafc7708822345ab469fc87b5c0b247074189
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-21T16:28:46Z

    added more test cases, changed vibrate with pattern durations, changed where vibrateOn is set to true

commit ab0c239e9c34f19e2c1e2f7d6fdc2df0679490d9
Author: Edna Morales <ed...@ednas-mbp-2.raleigh.ibm.com>
Date:   2014-07-21T19:41:51Z

    add longer pattern sequence for testing, change expected result for old vibrate with pattern test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: Cb 7138

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-vibration/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---