[GitHub] [camel-quarkus] aldettinger commented on pull request #3686: Camel-quarkus-datasonnet extension - resolves Issue #2078

[GitBox <gi...@apache.org>]

aldettinger commented on pull request #3686:
URL: https://github.com/apache/camel-quarkus/pull/3686#issuecomment-1085667060


   Hey, @javaduke it's really lovely to see contributions :)
   
   So, concerning the bom import order. It's better to change only at datasonnet level. I'm under the impression that it could still generate some issues with respect to enforcers and quarkus-platform. We'll see.
   
   Now, regarding the dslibs.jar, I see a bit more. At this stage, I would merely remove this part from testing. We try to avoid jar in sources as far as possible. Plus, I would assume most camel-quarkus users would define there libs in their own app ? And also, some tricks might be needed in native mode. Anyway, that could be another ticket.
   
   With ther2.8 release underway, it's maybe a better idea to review this PR next week with the embedded jar removed. That would already be a good first step :) Keep up the good work :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org