You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Brian DePradine (JIRA)" <ji...@apache.org> on 2006/08/09 20:46:14 UTC
[jira] Created: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
------------------------------------------------------------------------------------------------
Key: AXIS2-993
URL: http://issues.apache.org/jira/browse/AXIS2-993
Project: Apache Axis 2.0 (Axis2)
Issue Type: Improvement
Components: core
Reporter: Brian DePradine
Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [Axis2] Re: [jira] Commented: (AXIS2-993) org.apache.axis2.addressing.EndpointReference
should explicitly save the WS-Addressing namespace
Posted by Brian De Pradine <PR...@uk.ibm.com>.
"Eran Chinthaka (JIRA)" <ji...@apache.org> wrote on 17/08/2006 14:48:15:
> I'd like to keep it as it is and rather than implementing toOM and
> fromOM inside that, we can do the same using one of the following
> options, without touching the EPR class.
>
> 1. Extending from EPR class, we can have two different sub classes
> for two specs. But this must make sure that EPR class can be used as
> it is without its sub classes for some users, who do not want to
> worry abt the WS-A spec.
>
> 2. Delegate to a helper class for fromOM and toOM.
> AddressingHelper.toOM(epr, addressingNamespace)
> AddressingHelper.fromOM(omElement)
>
In order to move this forward, I propose that we do the following:
1. Change the signature of the helper methods to the following,
AddressingHelper.toOM(epr, qname, addressingNamespace)
AddressingHelper.fromOM(omElement, addressingNamespace)
AddressingHelper.fromOM(omElement)
The qname, passed to the toOM() method, is the name of the element that
will contain the EndpointRefereneceType. The addressingNamespace, passed
to the fromOM() method, is used to explicitly specify which namespace to
use for the deserialization. If the namespace of the omElement
EndpointReferenceType did not match this namespace then that would be a
fault.
2. Deprecate, or remove, toOM() and fromOM() from EndpointReference
3. Deprecate, or remove, setName() and getName() from EndpointReference
Does this sound reasonable?
Cheers
Brian DePradine
Web Services Development
IBM Hursley
External +44 (0) 1962 816319 Internal 246319
If you can't find the time to do it right the first time, where will you
find the time to do it again?
Re: [Axis2] Re: [jira] Commented: (AXIS2-993) org.apache.axis2.addressing.EndpointReference
should explicitly save the WS-Addressing namespace
Posted by Eran Chinthaka <ch...@opensource.lk>.
Brian De Pradine wrote:
>>
>> Brian,
>>
>> This is one of the problems I've been looking at for some time. IMO,
>> EndpointReference class better be independent of WS-A. We got the
>> attributed of the EPR class by looking at 2005/08 spec, but after
>> that it had nothing to do with that.
>
> Why does the EndpointReference class need to be independent of the
> WS-Addressing
> namespace? This is the aspect of this discussion that I haven't
> understood yet.
> Considering that in axis2 ALL EPRs are represented using instances of
> this class
> it seems to me that the addressing namespace is an important attribute
> to capture.
My only concern is EPR is used everywhere and it doesn't need to contain
WS-Addressing namespace in it. Its required only when you
serialize/de-serialize it.
For example, when you formulate a request to be sent and when you are
doing request-response invocation over the same HTTP channle, you don't
need to know anything about WS-Addressing. And no WS-Addressing modules
are required.
Thats why I like to keep EPR class independent from any namespace. For
me its just a bean which encapsulates information about an endpoint.
Serializing it using WS-A rules or any other rules is not its problem.
Yes, I agree its a problem if where to keep the code, both of us agree
on other stuff :)
-- Chinthaka
[Axis2] Re: [jira] Commented: (AXIS2-993) org.apache.axis2.addressing.EndpointReference
should explicitly save the WS-Addressing namespace
Posted by Brian De Pradine <PR...@uk.ibm.com>.
Hello all,
Eran suggested that we move this discussion to the axis-dev list. Please
find my comments below.
Cheers
Brian DePradine
Web Services Development
IBM Hursley
External +44 (0) 1962 816319 Internal 246319
If you can't find the time to do it right the first time, where will you
find the time to do it again?
"Eran Chinthaka (JIRA)" <ji...@apache.org> wrote on 17/08/2006 14:48:15:
> [ http://issues.apache.org/jira/browse/AXIS2-993?
> page=comments#action_12428656 ]
>
> Eran Chinthaka commented on AXIS2-993:
> --------------------------------------
>
> Brian,
>
> This is one of the problems I've been looking at for some time. IMO,
> EndpointReference class better be independent of WS-A. We got the
> attributed of the EPR class by looking at 2005/08 spec, but after
> that it had nothing to do with that.
Why does the EndpointReference class need to be independent of the
WS-Addressing
namespace? This is the aspect of this discussion that I haven't understood
yet.
Considering that in axis2 ALL EPRs are represented using instances of this
class
it seems to me that the addressing namespace is an important attribute to
capture.
> I'd like to keep it as it is and rather than implementing toOM and
> fromOM inside that, we can do the same using one of the following
> options, without touching the EPR class.
>
> 1. Extending from EPR class, we can have two different sub classes
> for two specs. But this must make sure that EPR class can be used as
> it is without its sub classes for some users, who do not want to
> worry abt the WS-A spec.
>
EndpointReference is currently used to represent EPRs for both specs, and
I believe that this works well. The change that I am proposing would
preserve this without the need for subclassing, which just adds complexity
for no extra benefit, in this case.
> 2. Delegate to a helper class for fromOM and toOM.
> AddressingHelper.toOM(epr, addressingNamespace)
> AddressingHelper.fromOM(omElement)
>
I think that we are probably in agreement that having methods to correctly
serialize/deserialize EPRs are a good thing. I believe that we differ on
where this code should live. I believe that this code should be in the
EndpointReference class, rather than some helper class, as this leads to
better encapsulation, and ultimately code that is easier to understand.
> For further discussions, if required, lets move this to axis-dev
> mailing list.
>
> -- Chinthaka
>
> > org.apache.axis2.addressing.EndpointReference should explicitly
> save the WS-Addressing namespace
> >
>
------------------------------------------------------------------------------------------------
> >
> > Key: AXIS2-993
> > URL: http://issues.apache.org/jira/browse/AXIS2-993
> > Project: Apache Axis 2.0 (Axis2)
> > Issue Type: Improvement
> > Components: Addressing
> > Reporter: Brian DePradine
> > Attachments: newerpatch.txt, newpatch.txt, patch.txt
> >
> >
> > Currently, the EndpointReference class always assumes that it is a
> representation of endpoint references based on the WS-Addressing
> 2005/08 (final) spec. However, this class is also used to represent
> endpoint references based on the 2004/08 (submission) spec. The
> problem is that the methods toOM() and fromOM() only work correctly
> in the former case. If the EndpointReference class is modified to
> explicitly save the WS-Addressing namespace then these methods can
> be made to work correctly for both specs. Patch to follow.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
[jira] Commented: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=comments#action_12428656 ]
Eran Chinthaka commented on AXIS2-993:
--------------------------------------
Brian,
This is one of the problems I've been looking at for some time. IMO, EndpointReference class better be independent of WS-A. We got the attributed of the EPR class by looking at 2005/08 spec, but after that it had nothing to do with that.
I'd like to keep it as it is and rather than implementing toOM and fromOM inside that, we can do the same using one of the following options, without touching the EPR class.
1. Extending from EPR class, we can have two different sub classes for two specs. But this must make sure that EPR class can be used as it is without its sub classes for some users, who do not want to worry abt the WS-A spec.
2. Delegate to a helper class for fromOM and toOM.
AddressingHelper.toOM(epr, addressingNamespace)
AddressingHelper.fromOM(omElement)
For further discussions, if required, lets move this to axis-dev mailing list.
-- Chinthaka
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Attachments: newerpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Davanum Srinivas updated AXIS2-993:
-----------------------------------
Priority: Blocker (was: Major)
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Priority: Blocker
> Attachments: newerpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Brian DePradine updated AXIS2-993:
----------------------------------
Attachment: finalpatch.txt
Submitting a final patch for this issue. Please ignore all previous patches.
1) The new helper methods are now in a class called EndpointReferenceHelper, which is a new class in the Addressing module. Anyone who uses these methods will now have an explicit dependency on the Addressing module.
2) Changed the method,
EndpointReference fromOM(OMElement eprElement, String addressingNamespace);
to
void fromOM(EndpointReference epr, OMElement eprElement, String addressingNamespace)
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Priority: Blocker
> Attachments: finalpatch.txt, newerpatch.txt, newestpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Brian DePradine updated AXIS2-993:
----------------------------------
Attachment: newerpatch.txt
Updated to a newer patch to reflect the new module organization.
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Reporter: Brian DePradine
> Attachments: newerpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=comments#action_12434392 ]
Brian DePradine commented on AXIS2-993:
---------------------------------------
Eran, I believe that option 2 is the preferrable option. I will submit a new patch that implements that option shortly.
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Priority: Blocker
> Attachments: newerpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Brian DePradine updated AXIS2-993:
----------------------------------
Attachment: newpatch.txt
Modified the javadoc slightly.
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Reporter: Brian DePradine
> Attachments: newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Eran Chinthaka resolved AXIS2-993.
----------------------------------
Resolution: Fixed
Fixed with commit : http://svn.apache.org/viewvc?view=rev&rev=447407
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Priority: Blocker
> Attachments: finalpatch.txt, newerpatch.txt, newestpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Brian DePradine updated AXIS2-993:
----------------------------------
Attachment: patch.txt
Here it is ...
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Reporter: Brian DePradine
> Attachments: patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Davanum Srinivas updated AXIS2-993:
-----------------------------------
Component/s: Addressing
(was: core)
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Attachments: newerpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=comments#action_12433911 ]
Eran Chinthaka commented on AXIS2-993:
--------------------------------------
Brian, whats the verdict on this? I sitll prefer option #2.
We better resolve this before Axis2 1.1
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Priority: Blocker
> Attachments: newerpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=comments#action_12427003 ]
Brian DePradine commented on AXIS2-993:
---------------------------------------
Please note that in the patch fromOM() now throws AxisFault.
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Reporter: Brian DePradine
> Attachments: patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-993)
org.apache.axis2.addressing.EndpointReference should explicitly save the
WS-Addressing namespace
Posted by "Brian DePradine (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-993?page=all ]
Brian DePradine updated AXIS2-993:
----------------------------------
Attachment: newestpatch.txt
Hi,
I have now updated my patch to do the following:
1) I have added three new methods to org.apache.axis2.addressing.AddressingHelper
OMElement toOM(EndpointReference epr, QName element, String addressingNamespace);
EndpointReference fromOM(OMElement eprElement);
EndpointReference fromOM(OMElement eprElement, String addressingNamespace);
2) I have deprecated the following methods on org.apache.axis2.addressing.EndpointReference
OMElement toOM(String nsurl, String localName, String prefix);
void fromOM(OMElement eprElement);
void setName(String localName);
String getName();
3) I have modified some code in the Savan module to use the new AddressingHelper.toOM() method. I passed in an addressing namespace of AddressingConstants.Submission.WSA_NAMESPACE. If this is not correct then I can change it.
> org.apache.axis2.addressing.EndpointReference should explicitly save the WS-Addressing namespace
> ------------------------------------------------------------------------------------------------
>
> Key: AXIS2-993
> URL: http://issues.apache.org/jira/browse/AXIS2-993
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: Addressing
> Reporter: Brian DePradine
> Priority: Blocker
> Attachments: newerpatch.txt, newestpatch.txt, newpatch.txt, patch.txt
>
>
> Currently, the EndpointReference class always assumes that it is a representation of endpoint references based on the WS-Addressing 2005/08 (final) spec. However, this class is also used to represent endpoint references based on the 2004/08 (submission) spec. The problem is that the methods toOM() and fromOM() only work correctly in the former case. If the EndpointReference class is modified to explicitly save the WS-Addressing namespace then these methods can be made to work correctly for both specs. Patch to follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org