You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/19 06:09:32 UTC

[GitHub] [airflow] potiuk opened a new pull request #21682: Switch to GitHub-rendered Mermaid diagrams

potiuk opened a new pull request #21682:
URL: https://github.com/apache/airflow/pull/21682


   We used mermaid diagrams in a few places and had pre-commit
   script to generate images out of them, but since GitHub
   introduced rendering of mermaid diagrams in javascript, we can
   now switch to markdown files with embedded mermaid markup.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21682:
URL: https://github.com/apache/airflow/pull/21682


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn commented on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1045877257


   If you allow me to suggest something, the graph of selective check could be better in this way (Just details) especially in the part of **Enable images**
   ```mermaid
   flowchart TD
   A(PR arrives)-->B[Selective Check]
   B-->C{Direct push merge?}
   C-->|Yes| N[Enable images] 
   N-->D(Run Full Test<br />+Quarantined<br />Run full static checks)
   C-->|No| E[Retrieve changed files]
   E-->F{Environment files changed?}
   F-->|Yes| N
   F-->|No| G{Docs changed}
   G-->|Yes| O[Enable images building]
   O-->I{Chart files changed?}
   G-->|No| I
   I-->|Yes| P[Enable helm tests]
   P-->J{API files changed}
   I-->|No| J
   J-->|Yes| Q[Enable API tests]
   Q-->H{Sources changed?}
   J-->|No| H
   H-->|Yes| R[Enable Pytests]
   R-->K[Determine test type]
   K-->S{Core files changed}
   S-->|Yes| N
   S-->|No| M(Run selected test+<br />Heisentest, Integration, Quarantined<br />Full static checks) 
   H-->|No| L[Skip running test<br />Run subset of static checks]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1051065388


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1045903523


   Of course. Updated. And added you as co-author :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1045856450


   cc: @edithturn -> I extracted some parts of the docs and I got the mermaid diagrams working :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn edited a comment on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
edithturn edited a comment on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1045877257


   @potiuk, If you allow me to suggest something, the graph of selective check could be better in this way (Just details) especially in the part of **Enable images**
   ```mermaid
   flowchart TD
   A(PR arrives)-->B[Selective Check]
   B-->C{Direct push merge?}
   C-->|Yes| N[Enable images] 
   N-->D(Run Full Test<br />+Quarantined<br />Run full static checks)
   C-->|No| E[Retrieve changed files]
   E-->F{Environment files changed?}
   F-->|Yes| N
   F-->|No| G{Docs changed}
   G-->|Yes| O[Enable images building]
   O-->I{Chart files changed?}
   G-->|No| I
   I-->|Yes| P[Enable helm tests]
   P-->J{API files changed}
   I-->|No| J
   J-->|Yes| Q[Enable API tests]
   Q-->H{Sources changed?}
   J-->|No| H
   H-->|Yes| R[Enable Pytests]
   R-->K[Determine test type]
   K-->S{Core files changed}
   S-->|Yes| N
   S-->|No| M(Run selected test+<br />Heisentest, Integration, Quarantined<br />Full static checks) 
   H-->|No| L[Skip running test<br />Run subset of static checks]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn commented on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1045866963


   wow! this is just amazing 🀩πŸ’ͺ🏾πŸ’ͺ🏾πŸ₯³. Wohooo!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21682: Switch to GitHub-rendered Mermaid diagrams

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21682:
URL: https://github.com/apache/airflow/pull/21682#issuecomment-1050212709


   Anyone? Removing another functionality that GitHub provided us for free. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org