You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/22 00:34:02 UTC

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8627

to look at the new patch set (#2).

Change subject: schema: fast-path for Schema::KeyEquals, etc.
......................................................................

schema: fast-path for Schema::KeyEquals, etc.

If two schemas are the same object, then KeyEquals can be fast-pathed.
The same goes for various ColumnSchema equality checks.

This hasn't been a hot path in release builds, but I noticed a lot of wasted
CPU in a debug build evaluating Schema::KeyEquals, and my suspicion is that in
a great number of cases the objects are identical. Even in release builds, may
as well avoid the unnecessary cycles.

Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
---
M src/kudu/common/schema.h
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8627/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>