You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Sylvain Laurent <sy...@gmail.com> on 2011/09/01 07:00:12 UTC
Re: svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/
Le 31 août 2011 à 23:13, Mark Thomas <ma...@apache.org> a écrit :
> On 31/08/2011 21:38, slaurent@apache.org wrote:
>> --- subclipse:tags (added)
>> +++ subclipse:tags Wed Aug 31 20:38:53 2011
>> @@ -0,0 +1,2 @@
>> +932358,branches,/tomcat/tc7.0.x/branches,branch
>> +1162976,TOMCAT_7_0_21,/tomcat/tc7.0.x/tags/TOMCAT_7_0_21,tag
>
> What is this? It looks like junk that needs to be removed to me.
>
It's part of subclipse support for tags and branches : http://subclipse.tigris.org/branch_tag.html
This is very convenient, and I don't think it bothers developers who don't use subclipse.
Sylvain
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/
Posted by Sylvain Laurent <sy...@m4x.org>.
On 1 sept. 2011, at 12:11, Konstantin Kolinko wrote:
> 1. What happens when someone creates a tag (aka svn copy) in another
> svn client? Should one remove the value, or leave it as is?
The value should be left as is. The next person that uses subclipse may update the value to include the reference to the new tag in the property value
>
> 2. It duplicates information that is already in repository.
> If it were just configuration value (e.g. "see tags there")...., but
> it lists all nn tags.
>
> 3. The property value on /tomcat/trunk was wrong.
Indeed, I should not have added it to /tomcat/trunk , only to /tomcat/tc7.0.x/trunk
>
> - it should not have been added there. You wouldn't list 7.0.x tags on trunk.
> - /tomcat/tc7.0.x/branches is not a branch
>
> A branch would be /tomcat/tc7.0.x/branches/<name>
Yes, my mistake
>
> Also message in this commit did not reflect what it did.
>
> 4. When I performed a trunk->7.0.x merge (see another email from
> yesterday) this revision caused property update conflict on
> 7.0.x/trunk. Maybe because of 3. above.
Yes, if I put the property only on /tomcat/tc7.0.x/trunk there won't be any conflict
>
> 5. What you, personally, use it for?
> What are your practical benefits? Seeing tag names in history?
Yes, I find it very convenient to see the history of changes on a file and the version of tomcat that includes the change.
>
> If you really use it and will add all TOMCAT_7_0_x tags to
> /tomcat/tc7.0.x/trunk, and will maintain it onwards, I personally do
> not mind.
ok, I will do it
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/
Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/9/1 Sylvain Laurent <sy...@gmail.com>:
> Le 31 août 2011 à 23:13, Mark Thomas <ma...@apache.org> a écrit :
>
>> On 31/08/2011 21:38, slaurent@apache.org wrote:
>>> --- subclipse:tags (added)
>>> +++ subclipse:tags Wed Aug 31 20:38:53 2011
>>> @@ -0,0 +1,2 @@
>>> +932358,branches,/tomcat/tc7.0.x/branches,branch
>>> +1162976,TOMCAT_7_0_21,/tomcat/tc7.0.x/tags/TOMCAT_7_0_21,tag
>>
>> What is this? It looks like junk that needs to be removed to me.
>>
> It's part of subclipse support for tags and branches :
> http://subclipse.tigris.org/branch_tag.html
>
> This is very convenient, and I don't think it bothers developers who don't use subclipse.
1. What happens when someone creates a tag (aka svn copy) in another
svn client? Should one remove the value, or leave it as is?
2. It duplicates information that is already in repository.
If it were just configuration value (e.g. "see tags there")...., but
it lists all nn tags.
3. The property value on /tomcat/trunk was wrong.
- it should not have been added there. You wouldn't list 7.0.x tags on trunk.
- /tomcat/tc7.0.x/branches is not a branch
A branch would be /tomcat/tc7.0.x/branches/<name>
Also message in this commit did not reflect what it did.
4. When I performed a trunk->7.0.x merge (see another email from
yesterday) this revision caused property update conflict on
7.0.x/trunk. Maybe because of 3. above.
5. What you, personally, use it for?
What are your practical benefits? Seeing tag names in history?
If you really use it and will add all TOMCAT_7_0_x tags to
/tomcat/tc7.0.x/trunk, and will maintain it onwards, I personally do
not mind.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org