You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by David Cromberge <dc...@apache.org> on 2022/11/01 16:29:14 UTC

Re: [VOTE] Release Apache DataSketches-cpp 3.5.1-rc3

+1

- Checked GPG and SHA
- Ran cmake and unit tests
- Tested local OSX install.

David

On 2022/10/31 20:08:35 Jon Malkin wrote:
> Hello Apache DataSketches PMC and Community,
> 
> 
> This is a call for vote to release Apache DataSketches-cpp candidate
> version 3.5.1-rc2
> 
> 
> This is a patch release intended to fix bugs in the previous release. We
> are gearing up for some API-breaking changes in a major release, and wanted
> to ensure that anyone who is not yet ready for that migration can benefit
> from these fixes.
> 
> 
> Changes since datasketches-cpp 3.5.0 release:
> 
>  - fix python wheel build script to produce valid wheels for Apple Silicon
> Macs
> 
>  - fix a serialization bug for theta and tuple sketches when sketch had no
> entries but was not empty (e.g. the result of an intersection between
> disjoint sets)
> 
> 
> Changes since rc1:
> 
>  - Should be using the correct GPG signing key (having found my original
> one)
> 
>  - Source should be entirely unchanged, down to using the same git hashid
> 
> 
> Change since rc2:
> 
>  - Had incorrect version (3.5.0) in CMakeLists.txt
> 
> 
> Source repository:
> 
>     - https://github.com/apache/datasketches-cpp
> 
> 
> Git Tag for this release:
> 
>     - https://github.com/apache/datasketches-cpp/releases/tag/3.5.1-rc3 on
> branch 3.5.x
> 
> 
> Git HashId for this release is: a44cb33ecdcb310e382d96e81e8a6cb63c044628
> 
> 
> The Release Candidate / Zip Repository, including convenience binaries (in
> pypi subdirectory):
> 
>     - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.1-rc3/
> 
> 
> The public signing key can be found in the KEYS file:
> 
>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> 
> 
> 
> The artifacts have been signed with key:
> 
>     21B541A98F6038F334CC 2020-04-30  Jon Malkin (Apache code signing) <
> jmalkin@users.noreply.github.com>
> 
> 
> Build & Test Guide (C++):
> 
>     - https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md
> 
> 
> Build & Test Guide (Python):
> 
>     - https://github.com/apache/datasketches-cpp/blob/3.5.x/python/README.md
> 
> 
> The vote will be performed as follows:
> 
>    - This letter will be published on dev@ and remain open for at least 72
> hours (excluding weekends and holidays), AND until at least 3 (+1) PMC votes or
> a majority of (+1) PMC votes are acquired. Anyone in the community can vote.
> 
> 
> Please vote accordingly:
> 
> 
> [ ] +1 approve
> 
> [ ] +0 no opinion
> 
> [ ] -1 disapprove with the reason
> 
> 
> Thank you,
> 
> Jon Malkin
> 
> jmalkin@apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [VOTE] Release Apache DataSketches-cpp 3.5.1-rc3

Posted by leerho <le...@gmail.com>.
+1 (binding)

Checked on MacOS 12.6.1:
- successfully downloaded source from dist
- installed, compiled and tested datasketches-cpp 3.5.1-rc3
- installed, compiled and tested Associated Python 3.5.1-rc3
- LICENSE and NOTICE are OK

Lee

On Tue, Nov 1, 2022 at 9:29 AM David Cromberge <dc...@apache.org>
wrote:

> +1
>
> - Checked GPG and SHA
> - Ran cmake and unit tests
> - Tested local OSX install.
>
> David
>
> On 2022/10/31 20:08:35 Jon Malkin wrote:
> > Hello Apache DataSketches PMC and Community,
> >
> >
> > This is a call for vote to release Apache DataSketches-cpp candidate
> > version 3.5.1-rc2
> >
> >
> > This is a patch release intended to fix bugs in the previous release. We
> > are gearing up for some API-breaking changes in a major release, and
> wanted
> > to ensure that anyone who is not yet ready for that migration can benefit
> > from these fixes.
> >
> >
> > Changes since datasketches-cpp 3.5.0 release:
> >
> >  - fix python wheel build script to produce valid wheels for Apple
> Silicon
> > Macs
> >
> >  - fix a serialization bug for theta and tuple sketches when sketch had
> no
> > entries but was not empty (e.g. the result of an intersection between
> > disjoint sets)
> >
> >
> > Changes since rc1:
> >
> >  - Should be using the correct GPG signing key (having found my original
> > one)
> >
> >  - Source should be entirely unchanged, down to using the same git hashid
> >
> >
> > Change since rc2:
> >
> >  - Had incorrect version (3.5.0) in CMakeLists.txt
> >
> >
> > Source repository:
> >
> >     - https://github.com/apache/datasketches-cpp
> >
> >
> > Git Tag for this release:
> >
> >     - https://github.com/apache/datasketches-cpp/releases/tag/3.5.1-rc3
> on
> > branch 3.5.x
> >
> >
> > Git HashId for this release is: a44cb33ecdcb310e382d96e81e8a6cb63c044628
> >
> >
> > The Release Candidate / Zip Repository, including convenience binaries
> (in
> > pypi subdirectory):
> >
> >     - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.1-rc3/
> >
> >
> > The public signing key can be found in the KEYS file:
> >
> >     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> >
> >
> >
> > The artifacts have been signed with key:
> >
> >     21B541A98F6038F334CC 2020-04-30  Jon Malkin (Apache code signing) <
> > jmalkin@users.noreply.github.com>
> >
> >
> > Build & Test Guide (C++):
> >
> >     - https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md
> >
> >
> > Build & Test Guide (Python):
> >
> >     -
> https://github.com/apache/datasketches-cpp/blob/3.5.x/python/README.md
> >
> >
> > The vote will be performed as follows:
> >
> >    - This letter will be published on dev@ and remain open for at least
> 72
> > hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> votes or
> > a majority of (+1) PMC votes are acquired. Anyone in the community can
> vote.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> > Thank you,
> >
> > Jon Malkin
> >
> > jmalkin@apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>