You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/26 23:05:37 UTC
Re: Review Request 42810: Added the CgroupInfo protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 10:05 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4488
https://issues.apache.org/jira/browse/MESOS-4488
Repository: mesos
Description
-------
Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
Diffs
-----
include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
Diff: https://reviews.apache.org/r/42810/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42810: Added the CgroupInfo protobuf.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/#review116511
-----------------------------------------------------------
include/mesos/v1/mesos.proto (line 1533)
<https://reviews.apache.org/r/42810/#comment177528>
Could you please make it nested in CgroupInfo?
- Jie Yu
On Jan. 26, 2016, 10:05 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42810/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 10:05 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4488
> https://issues.apache.org/jira/browse/MESOS-4488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
> include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
>
> Diff: https://reviews.apache.org/r/42810/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42810: Added the CgroupInfo protobuf.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/#review116487
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42810]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 26, 2016, 10:05 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42810/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 10:05 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4488
> https://issues.apache.org/jira/browse/MESOS-4488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
> include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
>
> Diff: https://reviews.apache.org/r/42810/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42810: Added the CgroupInfo protobuf.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/#review116805
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42810]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 28, 2016, 5:32 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42810/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 5:32 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4488
> https://issues.apache.org/jira/browse/MESOS-4488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
> include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8
>
> Diff: https://reviews.apache.org/r/42810/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42810: Added the CgroupInfo protobuf.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/
-----------------------------------------------------------
(Updated Jan. 28, 2016, 5:32 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added the CgroupInfo protobuf.
Bugs: MESOS-4488
https://issues.apache.org/jira/browse/MESOS-4488
Repository: mesos
Description
-------
Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
Diffs
-----
include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8
Diff: https://reviews.apache.org/r/42810/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42810: Added the CgroupInfo protobuf. The agent
can use
this message to reflect any cgroup configuration that might have been
applied to a container.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/
-----------------------------------------------------------
(Updated Jan. 28, 2016, 5:31 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
Bugs: MESOS-4488
https://issues.apache.org/jira/browse/MESOS-4488
Repository: mesos
Description
-------
Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.
Diffs (updated)
-----
include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247
include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8
Diff: https://reviews.apache.org/r/42810/diff/
Testing
-------
make
Thanks,
Avinash sridharan