You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2017/04/26 19:36:34 UTC

[GitHub] thrift pull request #1258: THRIFT-4183 Named pipe client blocks forever on O...

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/1258

    THRIFT-4183 Named pipe client blocks forever on Open() when there is \u2026

    \u2026no server at the other end
    
    Client: C#
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-4183

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1258
    
----
commit cee63d76b2847ecd4e844aded75cf546c88c33b3
Author: Jens Geyer <je...@apache.org>
Date:   2017-04-26T19:26:01Z

    THRIFT-4183 Named pipe client blocks forever on Open() when there is no server at the other end
    Client: C#
    Patch: Jens Geyer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1258: THRIFT-4183 Named pipe client blocks forever on Open() w...

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:

    https://github.com/apache/thrift/pull/1258
  
    That travis thing seems pretty reliable. The pobkly difference is in  the commit message, yet it fails where it succeeded minutes ago. Compare https://travis-ci.org/apache/thrift/builds/226143091 against https://travis-ci.org/apache/thrift/builds/226192720.
    
    @jeking3: Maybe. On the other hand, timeouts in C# are always msec, and the name is self-documenting. More comments would be helpful nevertheless, but that would be a much larger task to do it right. Too much for my little addition :-) Appreciate both review & comments though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1258: THRIFT-4183 Named pipe client blocks forever on O...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1258


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---