You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by "James L. Mitchell (JIRA)" <my...@incubator.apache.org> on 2005/07/12 06:32:24 UTC

[jira] Created: (MYFACES-322) Clean up source code

Clean up source code
--------------------

         Key: MYFACES-322
         URL: http://issues.apache.org/jira/browse/MYFACES-322
     Project: MyFaces
        Type: Improvement
    Versions: Nightly Build    
    Reporter: James L. Mitchell
    Priority: Minor


Here is a patch for removing:
 - all unused imports
 - unused local variables
 - unnecessary object creation
 - unused methods (not removed, just commented out)


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Re: [jira] Updated: (MYFACES-322) Clean up source code

Posted by Sean Schofield <se...@gmail.com>.

I believe Grant checked it in during one of his svn "marathons."

sean

On 7/13/05, Martin Marinschek <ma...@gmail.com> wrote:
> Sean, have you submitted the patch already?
> 
> I am just asking cause this will need to be done before we start again
> working on the codebase ;)
> 
> And of course we are very happy about having Struts gurus aboard,
> shame on you, grant ;)))
> 
> regards,
> 
> Martin
> 
> On 7/12/05, Grant Smith <gr...@marathon-man.com> wrote:
> > Sean Schofield wrote:
> >
> > >Its nice to have one of the Struts gurus on board.  Thanks for an
> > >excellent first patch.
> > >
> > >
> > Wait... he's a struts guru ? Reverse patch! Abort!! Abort!!
> >
>

Re: [jira] Updated: (MYFACES-322) Clean up source code

Posted by Martin Marinschek <ma...@gmail.com>.

Sean, have you submitted the patch already?

I am just asking cause this will need to be done before we start again
working on the codebase ;)

And of course we are very happy about having Struts gurus aboard,
shame on you, grant ;)))

regards,

Martin

On 7/12/05, Grant Smith <gr...@marathon-man.com> wrote:
> Sean Schofield wrote:
> 
> >Its nice to have one of the Struts gurus on board.  Thanks for an
> >excellent first patch.
> >
> >
> Wait... he's a struts guru ? Reverse patch! Abort!! Abort!!
>

Re: [jira] Updated: (MYFACES-322) Clean up source code

Posted by Grant Smith <gr...@marathon-man.com>.

Sean Schofield wrote:

>Its nice to have one of the Struts gurus on board.  Thanks for an
>excellent first patch.
>  
>
Wait... he's a struts guru ? Reverse patch! Abort!! Abort!!

Re: [jira] Updated: (MYFACES-322) Clean up source code

Posted by Sean Schofield <se...@gmail.com>.

Its nice to have one of the Struts gurus on board.  Thanks for an
excellent first patch.

sean

On 7/12/05, Martin Marinschek <ma...@gmail.com> wrote:
> woopaaaa!
> 
> now this is something to apply as a patch ;)
> 
> regards,
> 
> Martin
> 
> On 7/12/05, James L. Mitchell (JIRA) <my...@incubator.apache.org> wrote:
> >      [ http://issues.apache.org/jira/browse/MYFACES-322?page=all ]
> >
> > James L. Mitchell updated MYFACES-322:
> > --------------------------------------
> >
> >     Attachment: tomahawk.diff
> >
> > > Clean up source code
> > > --------------------
> > >
> > >          Key: MYFACES-322
> > >          URL: http://issues.apache.org/jira/browse/MYFACES-322
> > >      Project: MyFaces
> > >         Type: Improvement
> > >     Versions: Nightly Build
> > >     Reporter: James L. Mitchell
> > >     Priority: Minor
> > >  Attachments: api.diff, examples.diff, impl.diff, sandbox.diff, share.diff, tomahawk.diff
> > >
> > > Here is a patch for removing:
> > >  - all unused imports
> > >  - unused local variables
> > >  - unnecessary object creation
> > >  - unused methods (not removed, just commented out)
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators:
> >    http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> >    http://www.atlassian.com/software/jira
> >
> >
>