[GitHub] [airflow] shicholas commented on a change in pull request #20677: Opentelemetry instrumentation Flask

[GitBox <gi...@apache.org>]

shicholas commented on a change in pull request #20677:
URL: https://github.com/apache/airflow/pull/20677#discussion_r780850977



##########
File path: airflow/tracer.py
##########
@@ -0,0 +1,23 @@
+from opentelemetry import trace
+from opentelemetry.instrumentation.flask import FlaskInstrumentor
+from opentelemetry.instrumentation.requests import RequestsInstrumentor
+from opentelemetry.exporter.jaeger.thrift import JaegerExporter
+from opentelemetry.sdk.resources import SERVICE_NAME, Resource
+from opentelemetry.sdk.trace import TracerProvider
+from opentelemetry.sdk.trace.export import BatchSpanProcessor
+
+def init(service_name, metric_port):
+    jaeger_exporter = JaegerExporter(

Review comment:
       I'd consider using the `ConsoleSpanExporter` instead of Jaeger. Jaeger is great but requires extra steps like the server in the docker-compose file. The ConsoleSpan on the other hand just prints Open Telemetry spans to STDOUT.
   
   Will email about this too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org