You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/12 14:48:04 UTC

[GitHub] [arrow] fsaintjacques commented on pull request #7419: ARROW-8510: [C++][Datasets] Do not use variant in WritePlan to fix compiler error with VS 2017

fsaintjacques commented on pull request #7419:
URL: https://github.com/apache/arrow/pull/7419#issuecomment-643311800


   I also agree with the sentiment on variant, I noted this [here](https://github.com/apache/arrow/pull/7156#discussion_r435921179) (which touches the same code path). 
   
   While variant can elegantly solve issues in other languages, e.g. rust enums, it diverges from our current usage of interfaces and inheritance and seems to break some compilers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org