[GitHub] [superset] stevetracvc commented on a change in pull request #18009: feat: log scale and step size control for range filters [WIP]

[GitBox <gi...@apache.org>]

stevetracvc commented on a change in pull request #18009:
URL: https://github.com/apache/superset/pull/18009#discussion_r839603549



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
##########
@@ -214,6 +216,69 @@ export default function getControlItemsMap({
       );
       mapControlItems[controlItem.name] = { element, checked: initialValue };
     });
+  controlItems
+    .filter(
+      (controlItem: CustomControlItem) =>
+        controlItem?.config?.renderTrigger &&
+        controlItem.name !== 'sortAscending' &&

Review comment:
       You mean and just leave it to checking if it's a SelectControl? I'm fine with that but honestly I never checked what those other conditions are for. I just duplicated the previous section and tweaked it for a select :laughing: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org