[GitHub] [spark] cloud-fan commented on a change in pull request #35511: [SPARK-38203][SQL] Fix SQLInsertTestSuite and SchemaPruningSuite under ANSI mode

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35511:
URL: https://github.com/apache/spark/pull/35511#discussion_r806885208



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala
##########
@@ -286,20 +286,28 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils {
     } else {
       SQLConf.StoreAssignmentPolicy.values
     }
+
+    def shouldThrowException(policy: SQLConf.StoreAssignmentPolicy.Value): Boolean = policy match {
+      case SQLConf.StoreAssignmentPolicy.ANSI | SQLConf.StoreAssignmentPolicy.STRICT =>
+        true
+      case SQLConf.StoreAssignmentPolicy.LEGACY =>
+        SQLConf.get.ansiEnabled

Review comment:
       one argument here is shall we use non-ANSI cast for legacy store assignment. The legacy config is mostly for restoring the legacy behavior and I don't think ANSI mode should change it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org