You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/16 16:47:41 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1805: vfs: Create a node as the root of pseudo file system
xiaoxiang781216 opened a new pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805
## Summary
to remove the special process for root
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693564177
@davids5 done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-701251153
I am looking this, please wait a moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693797538
this patch introduced the following assertion failure.
@xiaoxiang781216 do you have any idea?
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
* frame #0: 0x00000001000009ef nuttx`up_assert(filename="inode/fs_inodereserve.c", line=125) at up_head.c:120:11
frame #1: 0x000000010001967b nuttx`_assert(filename="inode/fs_inodereserve.c", linenum=125) at lib_assert.c:36:3
frame #2: 0x0000000100116d0c nuttx`inode_insert(node=0x0000000100400070, peer=0x0000000000000000, parent=0x0000000000000000) at fs_inodereserve.c:125:7
frame #3: 0x0000000100116bf1 nuttx`inode_reserve(path="/dev/rtc0", inode=0x00007ffeefbff0a0) at fs_inodereserve.c:230:15
frame #4: 0x000000010011ce6f nuttx`register_driver(path="/dev/rtc0", fops=0x00000001001445b8, mode=438, priv=0x0000000100400050) at fs_registerdriver.c:78:9
frame #5: 0x0000000100017fbd nuttx`rtc_initialize(minor=0, lower=0x000000010014a6f0) at rtc.c:867:9
frame #6: 0x0000000100034870 nuttx`up_rtc_initialize at up_rtc.c:126:10
frame #7: 0x0000000100000b10 nuttx`clock_initialize at clock_initialize.c:226:3
frame #8: 0x0000000100002ffc nuttx`nx_start at nx_start.c:640:7
frame #9: 0x00000001000009a2 nuttx`main(argc=1, argv=0x00007ffeefbff218, envp=0x00007ffeefbff228) at up_head.c:96:7
frame #10: 0x00007fff7831b3d5 libdyld.dylib`start + 1
frame #11: 0x00007fff7831b3d5 libdyld.dylib`start + 1
(lldb)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693565540
Impact? Effects on other FS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693572930
I had this on my private TODO list: "Make root node a mountpoint so that it can be replaced or unified. Make pseudo file system into a true file system, auto-mounted at the root."
I am not sure if I made an Issue out that or not.
I don't think that this changes does all of that but seems to be a step in this direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693833511
> this patch introduced the following assertion failure.
> @xiaoxiang781216 do you have any idea?
>
> ```
> (lldb) bt
> * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
> * frame #0: 0x00000001000009ef nuttx`up_assert(filename="inode/fs_inodereserve.c", line=125) at up_head.c:120:11
> frame #1: 0x000000010001967b nuttx`_assert(filename="inode/fs_inodereserve.c", linenum=125) at lib_assert.c:36:3
> frame #2: 0x0000000100116d0c nuttx`inode_insert(node=0x0000000100400070, peer=0x0000000000000000, parent=0x0000000000000000) at fs_inodereserve.c:125:7
> frame #3: 0x0000000100116bf1 nuttx`inode_reserve(path="/dev/rtc0", inode=0x00007ffeefbff0a0) at fs_inodereserve.c:230:15
> frame #4: 0x000000010011ce6f nuttx`register_driver(path="/dev/rtc0", fops=0x00000001001445b8, mode=438, priv=0x0000000100400050) at fs_registerdriver.c:78:9
> frame #5: 0x0000000100017fbd nuttx`rtc_initialize(minor=0, lower=0x000000010014a6f0) at rtc.c:867:9
> frame #6: 0x0000000100034870 nuttx`up_rtc_initialize at up_rtc.c:126:10
> frame #7: 0x0000000100000b10 nuttx`clock_initialize at clock_initialize.c:226:3
> frame #8: 0x0000000100002ffc nuttx`nx_start at nx_start.c:640:7
> frame #9: 0x00000001000009a2 nuttx`main(argc=1, argv=0x00007ffeefbff218, envp=0x00007ffeefbff228) at up_head.c:96:7
> frame #10: 0x00007fff7831b3d5 libdyld.dylib`start + 1
> frame #11: 0x00007fff7831b3d5 libdyld.dylib`start + 1
> (lldb)
> ```
Look like clock_initialize is called before fs_initialize and then fs sytem isn't ready to accept the clock driver registration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693564177
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693591709
@patacongo shall we add the Todo as an issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693556119
@xiaoxiang781216 Would you please add mod details for this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693833511
> this patch introduced the following assertion failure.
> @xiaoxiang781216 do you have any idea?
>
> ```
> (lldb) bt
> * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
> * frame #0: 0x00000001000009ef nuttx`up_assert(filename="inode/fs_inodereserve.c", line=125) at up_head.c:120:11
> frame #1: 0x000000010001967b nuttx`_assert(filename="inode/fs_inodereserve.c", linenum=125) at lib_assert.c:36:3
> frame #2: 0x0000000100116d0c nuttx`inode_insert(node=0x0000000100400070, peer=0x0000000000000000, parent=0x0000000000000000) at fs_inodereserve.c:125:7
> frame #3: 0x0000000100116bf1 nuttx`inode_reserve(path="/dev/rtc0", inode=0x00007ffeefbff0a0) at fs_inodereserve.c:230:15
> frame #4: 0x000000010011ce6f nuttx`register_driver(path="/dev/rtc0", fops=0x00000001001445b8, mode=438, priv=0x0000000100400050) at fs_registerdriver.c:78:9
> frame #5: 0x0000000100017fbd nuttx`rtc_initialize(minor=0, lower=0x000000010014a6f0) at rtc.c:867:9
> frame #6: 0x0000000100034870 nuttx`up_rtc_initialize at up_rtc.c:126:10
> frame #7: 0x0000000100000b10 nuttx`clock_initialize at clock_initialize.c:226:3
> frame #8: 0x0000000100002ffc nuttx`nx_start at nx_start.c:640:7
> frame #9: 0x00000001000009a2 nuttx`main(argc=1, argv=0x00007ffeefbff218, envp=0x00007ffeefbff228) at up_head.c:96:7
> frame #10: 0x00007fff7831b3d5 libdyld.dylib`start + 1
> frame #11: 0x00007fff7831b3d5 libdyld.dylib`start + 1
> (lldb)
> ```
Look like clock_initialize is called before fs_initialize and then fs sytem isn't ready to register the clock driver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-700602070
HI @xiaoxiang781216
I noticed that the mount command now shows different behaviors than before.
Could you take a look at what is happening?
```
NuttShell (NSH) NuttX-9.1.0
nsh> mount
//proc type procfs
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1805: vfs: Create a node as the root of pseudo file system
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1805:
URL: https://github.com/apache/incubator-nuttx/pull/1805#issuecomment-693572930
I had this on my private TODO list: "Make root node a mountpoint so that it can be replaced or unified. Make pseudo file system into a true file system, auto-mounted at the root."
I am not sure if I made an Issue out that the or not.
I don't think that this changes does all of that but seems to be a step in this direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org