You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/17 03:26:48 UTC

[GitHub] [pinot] walterddr commented on a change in pull request #8361: adding jacoco inclusive rule

walterddr commented on a change in pull request #8361:
URL: https://github.com/apache/pinot/pull/8361#discussion_r828722785



##########
File path: pom.xml
##########
@@ -1612,6 +1612,11 @@
             </goals>
           </execution>
         </executions>
+        <configuration>
+          <includes>
+            <include>org/apache/pinot/**/*</include>

Review comment:
       per jacoco documentation it should be fine to assume jacoco only annotates code.
   that being said we might need to deal with the problem of generated code going forward. but I would leave that to future if it becomes an issue




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org