You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Sn0rt (via GitHub)" <gi...@apache.org> on 2023/05/10 09:00:52 UTC
[GitHub] [apisix] Sn0rt opened a new pull request, #9455: fix: allow serverless plugin empty user-agent
Sn0rt opened a new pull request, #9455:
URL: https://github.com/apache/apisix/pull/9455
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #9351
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird commented on code in PR #9455:
URL: https://github.com/apache/apisix/pull/9455#discussion_r1190534102
##########
apisix/plugins/serverless/generic-upstream.lua:
##########
@@ -35,6 +35,7 @@ return function(plugin_name, version, priority, request_processor, authz_schema,
function_uri = {type = "string"},
authorization = authz_schema,
timeout = {type = "integer", minimum = 100, default = 3000},
+ use_default_user_agent = {type = "boolean", default = true},
Review Comment:
I think we can set the default value to false, which can reduce the cost of users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on code in PR #9455:
URL: https://github.com/apache/apisix/pull/9455#discussion_r1193072250
##########
apisix/plugins/serverless/generic-upstream.lua:
##########
@@ -35,6 +35,7 @@ return function(plugin_name, version, priority, request_processor, authz_schema,
function_uri = {type = "string"},
authorization = authz_schema,
timeout = {type = "integer", minimum = 100, default = 3000},
+ use_default_user_agent = {type = "boolean", default = true},
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 closed pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 closed pull request #9455: fix: allow serverless plugin empty user-agent
URL: https://github.com/apache/apisix/pull/9455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird commented on code in PR #9455:
URL: https://github.com/apache/apisix/pull/9455#discussion_r1192027283
##########
apisix/plugins/serverless/generic-upstream.lua:
##########
@@ -35,6 +35,7 @@ return function(plugin_name, version, priority, request_processor, authz_schema,
function_uri = {type = "string"},
authorization = authz_schema,
timeout = {type = "integer", minimum = 100, default = 3000},
+ use_default_user_agent = {type = "boolean", default = true},
Review Comment:
The default value of use_default_user_agent is best set to false, which can reduce the cost of understanding for users. This default UA doesn't make sense for most users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on code in PR #9455:
URL: https://github.com/apache/apisix/pull/9455#discussion_r1192031204
##########
apisix/plugins/serverless/generic-upstream.lua:
##########
@@ -35,6 +35,7 @@ return function(plugin_name, version, priority, request_processor, authz_schema,
function_uri = {type = "string"},
authorization = authz_schema,
timeout = {type = "integer", minimum = 100, default = 3000},
+ use_default_user_agent = {type = "boolean", default = true},
Review Comment:
sounds reasonable. the reason to set the default value as true, which is the original logic of the program.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9455:
URL: https://github.com/apache/apisix/pull/9455#issuecomment-1569366117
I will close this pr, feel free to reopen it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Sn0rt commented on pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on PR #9455:
URL: https://github.com/apache/apisix/pull/9455#issuecomment-1541635149
@soulbird pls help to review the design
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Sn0rt commented on a diff in pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on code in PR #9455:
URL: https://github.com/apache/apisix/pull/9455#discussion_r1193072250
##########
apisix/plugins/serverless/generic-upstream.lua:
##########
@@ -35,6 +35,7 @@ return function(plugin_name, version, priority, request_processor, authz_schema,
function_uri = {type = "string"},
authorization = authz_schema,
timeout = {type = "integer", minimum = 100, default = 3000},
+ use_default_user_agent = {type = "boolean", default = true},
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9455: fix: allow serverless plugin empty user-agent
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9455:
URL: https://github.com/apache/apisix/pull/9455#issuecomment-1560343348
is this pr still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org