Change in asterixdb[master]: [ASTERIXDB-2344] LIMIT pushdown for primary index

["Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>]

Taewoo Kim has posted comments on this change.

Change subject: [ASTERIXDB-2344] LIMIT pushdown for primary index
......................................................................


Patch Set 17: Code-Review+1

LGTM. I only have a few minor comments.

#1. Do we want to keep the optimizer tests? or just use runtime test framework? It looks like you are using the runtime test to generate the plan and check it without introducing the optimizer tests.

#2. Can you add a description to each test? What are they supposed to check?

#3. Before declaring outputLimit, selectCondition, and tupleFilterFactory variables in each class, can we add a simple comment about them? What's the purpose of them?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2541
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I824fcad79995325e12a1a81d629160025294b915
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <cl...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cl...@uci.edu>
Gerrit-Reviewer: Taewoo Kim (please use wangsaeu@gmail.com) <ta...@uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No