You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/08 12:46:07 UTC
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5101: Support remove schema dynamically#step 1&2
terrymanu commented on a change in pull request #5101: Support remove schema dynamically#step 1&2
URL: https://github.com/apache/incubator-shardingsphere/pull/5101#discussion_r405495986
##########
File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloCenterRepository.java
##########
@@ -103,6 +103,11 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
configWrapper.addChangeListener(listener, Collections.singleton(apolloKey), Collections.singleton(apolloKey));
}
+ @Override
+ public void delete(final String key) {
+ openApiWrapper.remove(ConfigKeyUtils.path2Key(key));
Review comment:
Please do not use abbreviation, `pathToKey` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services