[GitHub] [flink] GJL commented on a change in pull request #11542: [FLINK-16303][rest] Enable retrieval of custom JobManager log files

[GitBox <gi...@apache.org>]

GJL commented on a change in pull request #11542: [FLINK-16303][rest] Enable retrieval of custom JobManager log files
URL: https://github.com/apache/flink/pull/11542#discussion_r401649499
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/cluster/JobManagerLogListHeaders.java
 ##########
 @@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.cluster;
+
+import org.apache.flink.runtime.rest.HttpMethodWrapper;
+import org.apache.flink.runtime.rest.handler.cluster.JobManagerLogListHandler;
+import org.apache.flink.runtime.rest.messages.EmptyMessageParameters;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.LogListInfo;
+import org.apache.flink.runtime.rest.messages.MessageHeaders;
+
+import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
+
+/**
+ * Headers for the {@link JobManagerLogListHandler}.
+ */
+public class JobManagerLogListHeaders implements MessageHeaders<EmptyRequestBody, LogListInfo, EmptyMessageParameters> {
+
+	private static final JobManagerLogListHeaders INSTANCE = new JobManagerLogListHeaders();
+
+	private static final String URL = "/jobmanager/logs";
+
+	private JobManagerLogListHeaders() {}
+
+	public static JobManagerLogListHeaders getInstance() {
+		return INSTANCE;
+	}
+
+	@Override
+	public Class<LogListInfo> getResponseClass() {
+		return LogListInfo.class;
+	}
+
+	@Override
+	public HttpResponseStatus getResponseStatusCode() {
+		return HttpResponseStatus.OK;
+	}
+
+	@Override
+	public String getDescription() {
+		return "Returns the list of log files on JobManager.";
 
 Review comment:
   _[...] on the JobManager_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services